feat: allow to custom service account name#6393
Merged
zirain merged 8 commits intoenvoyproxy:mainfrom Jul 3, 2025
Merged
Conversation
zirain
force-pushed
the
impl-envoyproxy-sa-name
branch
2 times, most recently
from
7af0961 to
86cf980
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6393 +/- ##
==========================================
+ Coverage 70.86% 70.88% +0.02%
==========================================
Files 220 220
Lines 37265 37285 +20
==========================================
+ Hits 26407 26431 +24
+ Misses 9309 9306 -3
+ Partials 1549 1548 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zirain
force-pushed
the
impl-envoyproxy-sa-name
branch
2 times, most recently
from
5918f7b to
d3feb73
Compare
zirain
force-pushed
the
impl-envoyproxy-sa-name
branch
2 times, most recently
from
466f4c6 to
2c15dc8
Compare
arkodg
reviewed
Jun 26, 2025
zirain
force-pushed
the
impl-envoyproxy-sa-name
branch
from
2c15dc8 to
1d7fa20
Compare
zirain
force-pushed
the
impl-envoyproxy-sa-name
branch
from
b30cac1 to
b691d5a
Compare
arkodg
reviewed
Jul 1, 2025
rudrakhp
previously approved these changes
Jul 3, 2025
Member
|
@zirain can you run gen-check and push your changes again? Looks like some new files were added. |
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
zirain
force-pushed
the
impl-envoyproxy-sa-name
branch
from
48b100d to
7b886d1
Compare
rudrakhp
approved these changes
Jul 3, 2025
tjvdmolen
pushed a commit
to tjvdmolen/gateway
that referenced
this pull request
Jul 11, 2025
* impl custom envoy sa name Signed-off-by: zirain <zirain2009@gmail.com> * address comment Signed-off-by: zirain <zirain2009@gmail.com> * lint Signed-off-by: zirain <zirain2009@gmail.com> * create sa with custom name Signed-off-by: zirain <zirain2009@gmail.com> * fix lint and test Signed-off-by: zirain <zirain2009@gmail.com> * fix test Signed-off-by: zirain <zirain2009@gmail.com> * fix Signed-off-by: zirain <zirain2009@gmail.com> * fix gen Signed-off-by: zirain <zirain2009@gmail.com> --------- Signed-off-by: zirain <zirain2009@gmail.com> Signed-off-by: Tjeerd Jan van der Molen <34071+tjvdmolen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
impl: #6360