feat: support user provided name for generated HPA and PDB#6337
Merged
arkodg merged 4 commits intoenvoyproxy:mainfrom Jun 18, 2025
Merged
feat: support user provided name for generated HPA and PDB#6337arkodg merged 4 commits intoenvoyproxy:mainfrom
arkodg merged 4 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Shahar Harari <shahar.harari@sap.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6337 +/- ##
==========================================
+ Coverage 70.62% 70.66% +0.03%
==========================================
Files 220 220
Lines 36941 36954 +13
==========================================
+ Hits 26090 26112 +22
+ Misses 9314 9308 -6
+ Partials 1537 1534 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Shahar Harari <shahar.harari@sap.com>
Signed-off-by: shahar-h <shahar.harari@sap.com>
Contributor
Author
|
/retest |
Member
|
do we still need this as we support gateway namespace mode? |
Member
|
/retest |
Contributor
Yes for default case ( non GNM case ) |
zirain
approved these changes
Jun 18, 2025
Member
|
it would be better to update the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add support for configuring user provided name for generated HPA and PDB resources, similar to Deployment, DaemonSet and Service.
Release Notes: Yes