api: allow to custom service account name#6360
Merged
zirain merged 2 commits intoenvoyproxy:mainfrom Jun 24, 2025
Merged
Conversation
zirain
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6360 +/- ##
==========================================
- Coverage 70.76% 70.74% -0.03%
==========================================
Files 220 220
Lines 37089 37089
==========================================
- Hits 26246 26237 -9
- Misses 9306 9312 +6
- Partials 1537 1540 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arkodg
reviewed
Jun 21, 2025
zirain
changed the title
zirain
force-pushed
the
envoy-sa-name
branch
3 times, most recently
from
d44ecaf to
094b53d
Compare
Signed-off-by: zirain <zirain2009@gmail.com>
arkodg
approved these changes
Jun 23, 2025
zhaohuabing
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this, users are able to use an existing sa for the proxy which contains a sidecar required additional role/permission.