Use cluster.loadBalancingPolicy instead of commonLbConfig#5833
Merged
arkodg merged 7 commits intoenvoyproxy:mainfrom Jul 7, 2025
Merged
Use cluster.loadBalancingPolicy instead of commonLbConfig#5833arkodg merged 7 commits intoenvoyproxy:mainfrom
arkodg merged 7 commits intoenvoyproxy:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5833 +/- ##
==========================================
- Coverage 70.81% 70.74% -0.07%
==========================================
Files 220 220
Lines 37582 37581 -1
==========================================
- Hits 26613 26588 -25
- Misses 9412 9428 +16
- Partials 1557 1565 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/retest |
2 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
zirain
approved these changes
Apr 29, 2025
zirain
previously approved these changes
Apr 29, 2025
Contributor
Author
|
I'll reopen after some other pending MRs |
Contributor
|
thanks @jukie, lets get this PR into v1.5 |
Contributor
Author
|
This doesn't depend on any upstream changes so we could still get it into 1.4.x but just waiting until after other planned changes are in to avoid conflicts |
jukie
force-pushed
the
use-cluster-loadBalancingPolicy
branch
from
6f84035 to
ae50c94
Compare
Contributor
Author
|
Would like to start implementation for LoadBalancer.ZoneAware from #6154 but wanted to get this in first. |
jukie
commented
Jul 3, 2025
internal/xds/translator/testdata/out/xds-ir/http-route-dynamic-resolver.clusters.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
zirain
force-pushed
the
use-cluster-loadBalancingPolicy
branch
from
0b3c4fe to
403e10c
Compare
zirain
previously approved these changes
Jul 4, 2025
arkodg
reviewed
Jul 7, 2025
arkodg
reviewed
Jul 7, 2025
Signed-off-by: Jukie <10012479+Jukie@users.noreply.github.com>
Contributor
Author
|
/retest |
zirain
approved these changes
Jul 7, 2025
arkodg
approved these changes
Jul 7, 2025
tjvdmolen
pushed a commit
to tjvdmolen/gateway
that referenced
this pull request
Jul 11, 2025
…#5833) * Use cluster.loadBalancingPolicy instead of commonLbConfig Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com> Signed-off-by: Tjeerd Jan van der Molen <34071+tjvdmolen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Uses cluster.loadBalancingPolicy instead of commonLbConfig for access to all available fields during load balancer configuration.
Which issue(s) this PR fixes:
Fixes #5834
Release Notes: No