api: add zoneAware lb config#6154
Conversation
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6154 +/- ##
==========================================
- Coverage 70.85% 70.84% -0.01%
==========================================
Files 220 220
Lines 37177 37177
==========================================
- Hits 26341 26338 -3
- Misses 9294 9296 +2
- Partials 1542 1543 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
jukie
force-pushed
the
api-locality-routing-config
branch
from
f7db49a to
d0d1373
Compare
|
/retest |
|
/retest |
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
|
/retest |
api/v1alpha1/loadbalancer_types.go
Outdated
| // | ||
| // +optional | ||
| // +notImplementedHide | ||
| MinEndpointsCount *uint64 `json:"minEndpointsCount,omitempty"` |
There was a problem hiding this comment.
thoughts on MinEndpointsThreshold ?
There was a problem hiding this comment.
wdyt @envoyproxy/gateway-maintainers
There was a problem hiding this comment.
For consistency, IMO we should align the naming of minEndpointsCount and minEndpointsInZoneCount. If we're switching to Threshold, lets apply to both? Fine with both 👍
There was a problem hiding this comment.
Yeah that's what I had assumed and changed both to use "Threshold"
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
Signed-off-by: jukie <10012479+Jukie@users.noreply.github.com>
jukie
changed the title
|
@rudrakhp could you take another look here? |
|
@jukie I missed this the first time, but looks like the json name for the attribute has not been updated here: gateway/api/v1alpha1/loadbalancer_types.go Line 168 in 7b7052c Can you please raise a quick fix for this, thanks! |
|
Good catch, will do! |
3 participants
What type of PR is this?
api: add ZoneAware field in BackendTrafficPolicy.LoadBalancer
What this PR does / why we need it:
Exposes explicit configuration for zone aware and locality weighted lb
Which issue(s) this PR fixes:
xRef #6025
Release Notes: No