Skip to content

Use cluster.loadBalancingPolicy instead of commonLbConfig #5833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkodg merged 7 commits into from
Jul 7, 2025
Merged

Use cluster.loadBalancingPolicy instead of commonLbConfig #5833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
08d172a
Use cluster.loadBalancingPolicy instead of commonLbConfig
jukie Jul 3, 2025
3c2ccd8
linting
jukie Jul 3, 2025
d487b9d
Fix dynamic resolver
jukie Jul 3, 2025
403e10c
regen
jukie Jul 4, 2025
aca6051
Merge branch 'main' into use-cluster-loadBalancingPolicy
jukie Jul 4, 2025
263bcfd
Merge branch 'main' into use-cluster-loadBalancingPolicy
jukie Jul 7, 2025
ae74b5c
Use ToAnyWithValidation
jukie Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 45 additions & 10 deletions internal/cmd/egctl/testdata/translate/out/default-resources.all.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,8 +815,7 @@ xds:
circuitBreakers:
thresholds:
- maxRetries: 1024
commonLbConfig:
localityWeightedLbConfig: {}
commonLbConfig: {}
connectTimeout: 10s
dnsLookupFamily: V4_PREFERRED
edsClusterConfig:
Expand All @@ -826,6 +825,14 @@ xds:
serviceName: httproute/default/backend/rule/0
ignoreHealthOnHostRemoval: true
lbPolicy: LEAST_REQUEST
loadBalancingPolicy:
policies:
- typedExtensionConfig:
name: envoy.load_balancing_policies.least_request
typedConfig:
'@type': type.googleapis.com/envoy.extensions.load_balancing_policies.least_request.v3.LeastRequest
localityLbConfig:
localityWeightedLbConfig: {}
metadata:
filterMetadata:
envoy-gateway:
Expand All @@ -842,8 +849,7 @@ xds:
circuitBreakers:
thresholds:
- maxRetries: 1024
commonLbConfig:
localityWeightedLbConfig: {}
commonLbConfig: {}
connectTimeout: 10s
dnsLookupFamily: V4_PREFERRED
edsClusterConfig:
Expand All @@ -853,6 +859,14 @@ xds:
serviceName: grpcroute/default/backend/rule/0
ignoreHealthOnHostRemoval: true
lbPolicy: LEAST_REQUEST
loadBalancingPolicy:
policies:
- typedExtensionConfig:
name: envoy.load_balancing_policies.least_request
typedConfig:
'@type': type.googleapis.com/envoy.extensions.load_balancing_policies.least_request.v3.LeastRequest
localityLbConfig:
localityWeightedLbConfig: {}
metadata:
filterMetadata:
envoy-gateway:
Expand All @@ -875,8 +889,7 @@ xds:
circuitBreakers:
thresholds:
- maxRetries: 1024
commonLbConfig:
localityWeightedLbConfig: {}
commonLbConfig: {}
connectTimeout: 10s
dnsLookupFamily: V4_PREFERRED
edsClusterConfig:
Expand All @@ -886,6 +899,14 @@ xds:
serviceName: tcproute/default/backend/rule/-1
ignoreHealthOnHostRemoval: true
lbPolicy: LEAST_REQUEST
loadBalancingPolicy:
policies:
- typedExtensionConfig:
name: envoy.load_balancing_policies.least_request
typedConfig:
'@type': type.googleapis.com/envoy.extensions.load_balancing_policies.least_request.v3.LeastRequest
localityLbConfig:
localityWeightedLbConfig: {}
metadata:
filterMetadata:
envoy-gateway:
Expand All @@ -901,8 +922,7 @@ xds:
circuitBreakers:
thresholds:
- maxRetries: 1024
commonLbConfig:
localityWeightedLbConfig: {}
commonLbConfig: {}
connectTimeout: 10s
dnsLookupFamily: V4_PREFERRED
edsClusterConfig:
Expand All @@ -912,6 +932,14 @@ xds:
serviceName: tlsroute/default/backend/rule/-1
ignoreHealthOnHostRemoval: true
lbPolicy: LEAST_REQUEST
loadBalancingPolicy:
policies:
- typedExtensionConfig:
name: envoy.load_balancing_policies.least_request
typedConfig:
'@type': type.googleapis.com/envoy.extensions.load_balancing_policies.least_request.v3.LeastRequest
localityLbConfig:
localityWeightedLbConfig: {}
metadata:
filterMetadata:
envoy-gateway:
Expand All @@ -927,8 +955,7 @@ xds:
circuitBreakers:
thresholds:
- maxRetries: 1024
commonLbConfig:
localityWeightedLbConfig: {}
commonLbConfig: {}
connectTimeout: 10s
dnsLookupFamily: V4_PREFERRED
edsClusterConfig:
Expand All @@ -938,6 +965,14 @@ xds:
serviceName: udproute/default/backend/rule/-1
ignoreHealthOnHostRemoval: true
lbPolicy: LEAST_REQUEST
loadBalancingPolicy:
policies:
- typedExtensionConfig:
name: envoy.load_balancing_policies.least_request
typedConfig:
'@type': type.googleapis.com/envoy.extensions.load_balancing_policies.least_request.v3.LeastRequest
localityLbConfig:
localityWeightedLbConfig: {}
metadata:
filterMetadata:
envoy-gateway:
Expand Down
11 changes: 9 additions & 2 deletions internal/cmd/egctl/testdata/translate/out/echo-gateway-api.cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,7 @@ xds:
circuitBreakers:
thresholds:
- maxRetries: 1024
commonLbConfig:
localityWeightedLbConfig: {}
commonLbConfig: {}
connectTimeout: 10s
dnsLookupFamily: V4_PREFERRED
edsClusterConfig:
Expand All @@ -117,6 +116,14 @@ xds:
serviceName: httproute/envoy-gateway-system/backend/rule/0
ignoreHealthOnHostRemoval: true
lbPolicy: LEAST_REQUEST
loadBalancingPolicy:
policies:
- typedExtensionConfig:
name: envoy.load_balancing_policies.least_request
typedConfig:
'@type': type.googleapis.com/envoy.extensions.load_balancing_policies.least_request.v3.LeastRequest
localityLbConfig:
localityWeightedLbConfig: {}
metadata:
filterMetadata:
envoy-gateway:
Expand Down
95 changes: 80 additions & 15 deletions internal/cmd/egctl/testdata/translate/out/from-gateway-api-to-xds.all.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,9 +491,7 @@
}
]
},
"commonLbConfig": {
"localityWeightedLbConfig": {}
},
"commonLbConfig": {},
"connectTimeout": "10s",
"dnsLookupFamily": "V4_PREFERRED",
"edsClusterConfig": {
Expand All @@ -505,6 +503,21 @@
},
"ignoreHealthOnHostRemoval": true,
"lbPolicy": "LEAST_REQUEST",
"loadBalancingPolicy": {
"policies": [
{
"typedExtensionConfig": {
"name": "envoy.load_balancing_policies.least_request",
"typedConfig": {
"@type": "type.googleapis.com/envoy.extensions.load_balancing_policies.least_request.v3.LeastRequest",
"localityLbConfig": {
"localityWeightedLbConfig": {}
}
}
}
}
]
},
"metadata": {
"filterMetadata": {
"envoy-gateway": {
Expand Down Expand Up @@ -533,9 +546,7 @@
}
]
},
"commonLbConfig": {
"localityWeightedLbConfig": {}
},
"commonLbConfig": {},
"connectTimeout": "10s",
"dnsLookupFamily": "V4_PREFERRED",
"edsClusterConfig": {
Expand All @@ -547,6 +558,21 @@
},
"ignoreHealthOnHostRemoval": true,
"lbPolicy": "LEAST_REQUEST",
"loadBalancingPolicy": {
"policies": [
{
"typedExtensionConfig": {
"name": "envoy.load_balancing_policies.least_request",
"typedConfig": {
"@type": "type.googleapis.com/envoy.extensions.load_balancing_policies.least_request.v3.LeastRequest",
"localityLbConfig": {
"localityWeightedLbConfig": {}
}
}
}
}
]
},
"metadata": {
"filterMetadata": {
"envoy-gateway": {
Expand Down Expand Up @@ -586,9 +612,7 @@
}
]
},
"commonLbConfig": {
"localityWeightedLbConfig": {}
},
"commonLbConfig": {},
"connectTimeout": "10s",
"dnsLookupFamily": "V4_PREFERRED",
"edsClusterConfig": {
Expand All @@ -600,6 +624,21 @@
},
"ignoreHealthOnHostRemoval": true,
"lbPolicy": "LEAST_REQUEST",
"loadBalancingPolicy": {
"policies": [
{
"typedExtensionConfig": {
"name": "envoy.load_balancing_policies.least_request",
"typedConfig": {
"@type": "type.googleapis.com/envoy.extensions.load_balancing_policies.least_request.v3.LeastRequest",
"localityLbConfig": {
"localityWeightedLbConfig": {}
}
}
}
}
]
},
"metadata": {
"filterMetadata": {
"envoy-gateway": {
Expand Down Expand Up @@ -628,9 +667,7 @@
}
]
},
"commonLbConfig": {
"localityWeightedLbConfig": {}
},
"commonLbConfig": {},
"connectTimeout": "10s",
"dnsLookupFamily": "V4_PREFERRED",
"edsClusterConfig": {
Expand All @@ -642,6 +679,21 @@
},
"ignoreHealthOnHostRemoval": true,
"lbPolicy": "LEAST_REQUEST",
"loadBalancingPolicy": {
"policies": [
{
"typedExtensionConfig": {
"name": "envoy.load_balancing_policies.least_request",
"typedConfig": {
"@type": "type.googleapis.com/envoy.extensions.load_balancing_policies.least_request.v3.LeastRequest",
"localityLbConfig": {
"localityWeightedLbConfig": {}
}
}
}
}
]
},
"metadata": {
"filterMetadata": {
"envoy-gateway": {
Expand Down Expand Up @@ -670,9 +722,7 @@
}
]
},
"commonLbConfig": {
"localityWeightedLbConfig": {}
},
"commonLbConfig": {},
"connectTimeout": "10s",
"dnsLookupFamily": "V4_PREFERRED",
"edsClusterConfig": {
Expand All @@ -684,6 +734,21 @@
},
"ignoreHealthOnHostRemoval": true,
"lbPolicy": "LEAST_REQUEST",
"loadBalancingPolicy": {
"policies": [
{
"typedExtensionConfig": {
"name": "envoy.load_balancing_policies.least_request",
"typedConfig": {
"@type": "type.googleapis.com/envoy.extensions.load_balancing_policies.least_request.v3.LeastRequest",
"localityLbConfig": {
"localityWeightedLbConfig": {}
}
}
}
}
]
},
"metadata": {
"filterMetadata": {
"envoy-gateway": {
Expand Down
Loading