thrift_proxy: migrate from v2alpha to v2#9900
Closed
rgs1 wants to merge 4 commits intoenvoyproxy:masterfrom
Closed
thrift_proxy: migrate from v2alpha to v2#9900rgs1 wants to merge 4 commits intoenvoyproxy:masterfrom
rgs1 wants to merge 4 commits intoenvoyproxy:masterfrom
Conversation
We've been using this in prod for a couple of months and for a few different services. A few critical bugs have been fixed (envoyproxy#9089 and envoyproxy#6549) and some necessary stats/features have been added (envoyproxy#9203 and envoyproxy#8994), so it's probably a good time to graduate this filter. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
lizan
suggested changes
Feb 1, 2020
Member
lizan
left a comment
lizan
left a comment
There was a problem hiding this comment.
We already boosted this into v3 (without alpha), I think you can just migrate to v3 configs instead of migrating v2alpha to v2?
Member
Author
and then what happens to v2alpha? It stays around until v2 is deprecated? |
added 2 commits
January 31, 2020 19:22
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Member
Right. |
Member
Author
Ok -- that works. I'll send a simpler PR then to just mark the filter as non-alpha. |
Member
Author
|
Follow-up in #9903. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been using this in prod for a couple of months and for
a few different services.
A few critical bugs have been fixed (#9089 and #6549) and some
necessary stats/features have been added (#9203 and #8994), so
it's probably a good time to graduate this filter.
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com