Merged
Conversation
After Router::onEvent() handles a local or remote close, it should also reset the upstream request to ensure another close() isn't issued when Router::onDestroy() is called. No tests added, but validated with @fishcakez's repro that this works properly. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
added 5 commits
November 20, 2019 18:56
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
When calling onDestroy -> resetStream, a call to onEvent() might be generated by the close() call. This in turn will free upstream_request_ which is a problem given that resetStream is running and it's a member of upstream_request_. This probably needs more work -- once ASAN/TSAN is happy -- to make it less convoluted. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Leftover. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
added 2 commits
November 21, 2019 19:18
Also adds Stephan's integration test. Validated this with our repro, it's good to go. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
rgs1
commented
Nov 21, 2019
source/extensions/filters/network/thrift_proxy/router/router_impl.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Member
Author
|
@zuercher failures are unrelated: Mind re-kicking the azure jobs? |
Member
|
/azp run envoy-linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
The macos failure is also unrelated: |
sthagen
added a commit
to sthagen/envoyproxy-envoy
that referenced
this pull request
Nov 22, 2019
thrift-proxy: fix crash (envoyproxy#9089)
rgs1
pushed a commit
to rgs1/envoy
that referenced
this pull request
Jan 31, 2020
We've been using this in prod for a couple of months and for a few different services. A few critical bugs have been fixed (envoyproxy#9089 and envoyproxy#6549) and some necessary stats/features have been added (envoyproxy#9203 and envoyproxy#8994), so it's probably a good time to graduate this filter. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
rgs1
pushed a commit
to rgs1/envoy
that referenced
this pull request
Feb 1, 2020
We've been using this in prod for a couple of months and for a few different services. A few critical bugs have been fixed (envoyproxy#9089 and envoyproxy#6549) and some necessary stats/features have been added (envoyproxy#9203 and envoyproxy#8994), so it's probably a good time to graduate at least the proxy and the router filter. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
mattklein123
pushed a commit
that referenced
this pull request
Feb 1, 2020
We've been using this in prod for a couple of months and for a few different services. A few critical bugs have been fixed (#9089 and #6549) and some necessary stats/features have been added (#9203 and #8994), so it's probably a good time to graduate at least the proxy and the router filter. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After Router::onEvent() handles a local or remote close, it should also
reset the upstream request to ensure another close() isn't issued
when Router::onDestroy() is called.
Added a unit test and also validated with @fishcakez's repro that this works
properly.
Fixes: #9037
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com