thrift proxy: add stats to the router filter#9203
Merged
zuercher merged 2 commits intoenvoyproxy:masterfrom Dec 4, 2019
Merged
thrift proxy: add stats to the router filter#9203zuercher merged 2 commits intoenvoyproxy:masterfrom
zuercher merged 2 commits intoenvoyproxy:masterfrom
Conversation
This adds stats for missing route, missing cluster, no healthy hosts, etc. Should be useful to protect operators against bad config pushes, plus gives more visibility. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Member
Author
|
failure seems unrelated: Test log: |
Member
Author
|
cc: @oschaaf for the above failure |
zuercher
reviewed
Dec 3, 2019
Member
zuercher
left a comment
There was a problem hiding this comment.
Thanks! I have thing to think about, but otherwise looks good.
zuercher
approved these changes
Dec 4, 2019
rgs1
pushed a commit
to rgs1/envoy
that referenced
this pull request
Jan 31, 2020
We've been using this in prod for a couple of months and for a few different services. A few critical bugs have been fixed (envoyproxy#9089 and envoyproxy#6549) and some necessary stats/features have been added (envoyproxy#9203 and envoyproxy#8994), so it's probably a good time to graduate this filter. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
rgs1
pushed a commit
to rgs1/envoy
that referenced
this pull request
Feb 1, 2020
We've been using this in prod for a couple of months and for a few different services. A few critical bugs have been fixed (envoyproxy#9089 and envoyproxy#6549) and some necessary stats/features have been added (envoyproxy#9203 and envoyproxy#8994), so it's probably a good time to graduate at least the proxy and the router filter. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
mattklein123
pushed a commit
that referenced
this pull request
Feb 1, 2020
We've been using this in prod for a couple of months and for a few different services. A few critical bugs have been fixed (#9089 and #6549) and some necessary stats/features have been added (#9203 and #8994), so it's probably a good time to graduate at least the proxy and the router filter. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds stats for missing route, missing cluster, no healthy hosts,
etc. Should be useful to protect operators against bad config pushes,
plus gives more visibility.
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com