stats: improve test-coverage for a few stats-related functions.#7038
Merged
jmarantz merged 6 commits intoenvoyproxy:masterfrom May 22, 2019
Merged
stats: improve test-coverage for a few stats-related functions.#7038jmarantz merged 6 commits intoenvoyproxy:masterfrom
jmarantz merged 6 commits intoenvoyproxy:masterfrom
Conversation
…re code. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
fredlas
previously approved these changes
May 22, 2019
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
requested changes
May 22, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for jumping on this. 2 questions.
/wait
ahedberg
suggested changes
May 22, 2019
Contributor
ahedberg
left a comment
ahedberg
left a comment
There was a problem hiding this comment.
LGTM modulo one naming suggestion.
…ot-well-thought-out. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
/retest |
|
🔨 rebuilding |
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
May 23, 2019
* master: test: Add coverage for IsolatedStoreImpl::find* (envoyproxy#7043) server: add ProcessContext (envoyproxy#7018) config: Implement both versions of onConfigUpdate() everywhere (envoyproxy#6879) gzip: add test for various compression strategy and level (envoyproxy#7055) Fix typo in comment for rds.RouteConfiguration.validate_clusters (envoyproxy#7056) mysql_filter: add handling for partial messages (envoyproxy#6885) migrate from v2alpha to v2 (envoyproxy#7044) tests: fix tsan test flake (envoyproxy#7052) upstream: fix HostUtility::healthFlagsToString (envoyproxy#7051) tech debt: eliminate absl::make_unique (envoyproxy#7034) router: add a route name field in route.Route list (envoyproxy#6776) ext_authz: configurable HTTP status code for network errors. (envoyproxy#6669) stats: remove const-cast for symbol-table in edcs_filter_test.cc (envoyproxy#7045) build: bump libevent to 3b1864b. (envoyproxy#7012) stats: improve test-coverage for a few stats-related functions. (envoyproxy#7038) docs: fix csrf filter source origin note (envoyproxy#7041) Fix common typo: grcp -> grpc (envoyproxy#7040) snapshot (envoyproxy#7036) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: A few methods had been left uncovered in tests. This addresses some of the issues called out in #7035 . @fredlas and @ahedberg should be able to cover the remainder. Note: when this is merged, #7035 should not be closed -- 2 more PRs will be needed.
This PR has a small refactor to help improve coverage. It renames the const variant of symbolTable() in various class hierarchies, to allow shared base-classes to provide a default implementation of constSymbolTable() based on a derived-class supplied symbolTable().
Risk Level: low
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a