ext_authz: configurable HTTP status code for network errors. by gsagula · Pull Request #6669 · envoyproxy/envoy

gsagula · 2019-04-22T00:49:29Z

Description: Adds a configurable HTTP status code that the filter will use to respond to the client when a network error occurs during the external authorization call.

Risk Level: Low
Testing: Yes
Docs Changes: Yes
Release Notes: Yes
Fixes #6119 #5974

Signed-off-by: Gabriel <gsagula@gmail.com>

…tus-on-error Signed-off-by: Gabriel gsagula@gmail.com

Signed-off-by: Gabriel <gsagula@gmail.com>

dio

Thanks, @gsagula! Looks good. Let's fix the conflicted files. I have several comments to start with:

docs/root/intro/version_history.rst

source/extensions/filters/http/ext_authz/ext_authz.cc

gsagula · 2019-04-23T18:18:09Z

@dio Thanks for the review. I'm dealing with some other issues but I will try to get back to it asap.

Signed-off-by: Gabriel <gsagula@gmail.com>

…tus-on-error Signed-off-by: Gabriel <gsagula@gmail.com>

Signed-off-by: Gabriel <gsagula@gmail.com>

gsagula · 2019-04-25T02:57:13Z

/retest

repokitteh-read-only · 2019-04-25T02:57:17Z

🔨 rebuilding ci/circleci: coverage (failed build)

🐱

Caused by: a #6669 (comment) was created by @gsagula.

see: more, trace.

gsagula · 2019-04-25T17:38:42Z

@dio PTAL. Thank you.

docs/root/intro/version_history.rst

…tus-on-error Signed-off-by: Gabriel <gsagula@gmail.com>

Signed-off-by: Gabriel <gsagula@gmail.com>

gsagula · 2019-04-26T17:41:36Z

@dio I fixed the version history order. Thanks!

docs/root/intro/version_history.rst

Signed-off-by: Gabriel <gsagula@gmail.com>

stale · 2019-05-04T00:40:08Z

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

gsagula · 2019-05-04T17:37:46Z

@dio Whenever you get time, please let me know if there is anything else that needs to be changed. Thanks!

dio

Sorry. This is good. Thanks @gsagula!

mattklein123

Thanks, 1 question/comment.

/wait

source/extensions/filters/http/ext_authz/ext_authz.h

stale · 2019-05-13T03:40:37Z

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

hanyu-liu

Looks like this will not work for gRPC based ext-authz? May introduce a behavioral difference between protocols.

Ref: #6148

gsagula · 2019-05-17T17:02:09Z

Sorry for the delay. Looking at this now.

Signed-off-by: Gabriel <gsagula@gmail.com>

…tus-on-error Signed-off-by: Gabriel <gsagula@gmail.com>

mattklein123

Thanks!

* master: test: Add coverage for IsolatedStoreImpl::find* (envoyproxy#7043) server: add ProcessContext (envoyproxy#7018) config: Implement both versions of onConfigUpdate() everywhere (envoyproxy#6879) gzip: add test for various compression strategy and level (envoyproxy#7055) Fix typo in comment for rds.RouteConfiguration.validate_clusters (envoyproxy#7056) mysql_filter: add handling for partial messages (envoyproxy#6885) migrate from v2alpha to v2 (envoyproxy#7044) tests: fix tsan test flake (envoyproxy#7052) upstream: fix HostUtility::healthFlagsToString (envoyproxy#7051) tech debt: eliminate absl::make_unique (envoyproxy#7034) router: add a route name field in route.Route list (envoyproxy#6776) ext_authz: configurable HTTP status code for network errors. (envoyproxy#6669) stats: remove const-cast for symbol-table in edcs_filter_test.cc (envoyproxy#7045) build: bump libevent to 3b1864b. (envoyproxy#7012) stats: improve test-coverage for a few stats-related functions. (envoyproxy#7038) docs: fix csrf filter source origin note (envoyproxy#7041) Fix common typo: grcp -> grpc (envoyproxy#7040) snapshot (envoyproxy#7036) Signed-off-by: Michael Puncel <mpuncel@squareup.com>

Gabriel added 5 commits April 13, 2019 19:20

wip: saving the work

9d38e5b

Signed-off-by: Gabriel <gsagula@gmail.com>

reorginized code and added tests

cd3cf95

Signed-off-by: Gabriel <gsagula@gmail.com>

Merge branch 'master' of https://github.com/envoyproxy/envoy into sta…

067bb85

…tus-on-error Signed-off-by: Gabriel gsagula@gmail.com

fixed format and added release notes

48e0993

Signed-off-by: Gabriel <gsagula@gmail.com>

fixed typo

706b249

Signed-off-by: Gabriel <gsagula@gmail.com>

junr03 assigned dio Apr 22, 2019

dio suggested changes Apr 23, 2019

View reviewed changes

docs/root/intro/version_history.rst Outdated Show resolved Hide resolved

source/extensions/filters/http/ext_authz/ext_authz.cc Outdated Show resolved Hide resolved

source/extensions/filters/http/ext_authz/ext_authz.cc Show resolved Hide resolved

Gabriel added 3 commits April 24, 2019 15:54

code review changes

8c8640e

Signed-off-by: Gabriel <gsagula@gmail.com>

Merge branch 'master' of https://github.com/envoyproxy/envoy into sta…

be7a98a

…tus-on-error Signed-off-by: Gabriel <gsagula@gmail.com>

fixed logger message

b881d69

Signed-off-by: Gabriel <gsagula@gmail.com>

dio reviewed Apr 26, 2019

View reviewed changes

docs/root/intro/version_history.rst Outdated Show resolved Hide resolved

Gabriel added 2 commits April 26, 2019 10:16

Merge branch 'master' of https://github.com/envoyproxy/envoy into sta…

4d7efa9

…tus-on-error Signed-off-by: Gabriel <gsagula@gmail.com>

edited version history

5487d9f

Signed-off-by: Gabriel <gsagula@gmail.com>

dio reviewed Apr 26, 2019

View reviewed changes

docs/root/intro/version_history.rst Outdated Show resolved Hide resolved

Gabriel added 2 commits April 26, 2019 15:03

fixed version alpha order

77b190f

Signed-off-by: Gabriel <gsagula@gmail.com>

Merge remote-tracking branch 'upstream/master' into status-on-error

1ab6dcf

Signed-off-by: Gabriel <gsagula@gmail.com>

stale bot added the stale stalebot believes this issue/PR has not been touched recently label May 4, 2019

stale bot removed the stale stalebot believes this issue/PR has not been touched recently label May 4, 2019

dio previously approved these changes May 5, 2019

View reviewed changes

mattklein123 requested changes May 6, 2019

View reviewed changes

source/extensions/filters/http/ext_authz/ext_authz.h Show resolved Hide resolved

repokitteh-read-only bot added the waiting label May 6, 2019

mattklein123 self-assigned this May 6, 2019

stale bot added stale stalebot believes this issue/PR has not been touched recently and removed stale stalebot believes this issue/PR has not been touched recently labels May 13, 2019

hanyu-liu suggested changes May 14, 2019

View reviewed changes

code review changes

68ba804

Signed-off-by: Gabriel <gsagula@gmail.com>

gsagula dismissed dio’s stale review via 68ba804 May 21, 2019 18:28

repokitteh-read-only bot removed the waiting label May 21, 2019

Gabriel added 4 commits May 21, 2019 11:30

Merge remote-tracking branch 'upstream/master' into status-on-error

2079ab9

Signed-off-by: Gabriel <gsagula@gmail.com>

fixed conflict

9e5a64a

Signed-off-by: Gabriel <gsagula@gmail.com>

Merge remote-tracking branch 'upstream/master' into status-on-error

866706b

Signed-off-by: Gabriel <gsagula@gmail.com>

Merge branch 'master' of https://github.com/envoyproxy/envoy into sta…

9d5224f

…tus-on-error Signed-off-by: Gabriel <gsagula@gmail.com>

mattklein123 approved these changes May 22, 2019

View reviewed changes

mattklein123 merged commit b0c3683 into envoyproxy:master May 23, 2019

Conversation

gsagula commented Apr 22, 2019

Uh oh!

dio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gsagula commented Apr 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gsagula commented Apr 25, 2019

Uh oh!

repokitteh-read-only bot commented Apr 25, 2019

Uh oh!

gsagula commented Apr 25, 2019

Uh oh!

Uh oh!

gsagula commented Apr 26, 2019

Uh oh!

Uh oh!

stale bot commented May 4, 2019

Uh oh!

gsagula commented May 4, 2019

Uh oh!

dio left a comment

Choose a reason for hiding this comment

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stale bot commented May 13, 2019

Uh oh!

hanyu-liu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gsagula commented May 17, 2019

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gsagula commented Apr 23, 2019 •

edited

Loading

hanyu-liu left a comment •

edited

Loading