http1: enable reads when final pipeline response received#6578
Merged
mattklein123 merged 2 commits intomasterfrom Apr 15, 2019
Merged
http1: enable reads when final pipeline response received#6578mattklein123 merged 2 commits intomasterfrom
mattklein123 merged 2 commits intomasterfrom
Conversation
Previously we were doing this when we create a new stream, but on a reused connection this can lead to us missing an upstream disconnection when the connection is placed back in the pool. Fixes #6190 Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
lizan
approved these changes
Apr 15, 2019
|
This is great. What's the story for http2? |
Contributor
|
H2 doesn't read disable, it marks the stream flow control blocked, and the used window is reclaimed on stream destruction: |
Contributor
|
@duderino Hello. Which istio release we are expecting to include this fix? Thank you. |
lambdai
pushed a commit
to lambdai/envoy-dai
that referenced
this pull request
May 29, 2019
…#6578) Previously we were doing this when we create a new stream, but on a reused connection this can lead to us missing an upstream disconnection when the connection is placed back in the pool. Fixes envoyproxy#6190 Signed-off-by: Matt Klein <mklein@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were doing this when we create a new stream, but on
a reused connection this can lead to us missing an upstream
disconnection when the connection is placed back in the pool.
Fixes #6190
Risk Level: Medium. Scary stuff but well tested.
Testing: Modified existing UT.
Docs Changes: N/A
Release Notes: N/A