Skip to content

test: router upstream log to v2 config stubs#6499

Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
derekargueta:dereka/router-upstream-log-test
Apr 8, 2019
Merged

test: router upstream log to v2 config stubs#6499
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
derekargueta:dereka/router-upstream-log-test

Conversation

@derekargueta
Copy link
Member

@derekargueta derekargueta commented Apr 6, 2019

short PR towards #6362
Risk Level: Low (no functional change)
Testing: included
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Derek Argueta <dereka@pinterest.com>
Signed-off-by: Derek Argueta <dereka@pinterest.com>
@derekargueta
Copy link
Member Author

/retest

@repokitteh-read-only
Copy link

🔨 rebuilding ci/circleci: coverage (failed build)

🐱

Caused by: a #6499 (comment) was created by @derekargueta.

see: more, trace.

@derekargueta
Copy link
Member Author

derekargueta commented Apr 6, 2019

Code coverage 97.4 is lower than limit of 97.5
I guess I'll find a test to add to compensate

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Coverage will be fixed if you merge master but will just go ahead and merge for you.

@mattklein123 mattklein123 merged commit 22a9b8c into envoyproxy:master Apr 8, 2019
mpuncel added a commit to mpuncel/envoy that referenced this pull request Apr 8, 2019
* master: (137 commits)
  test: router upstream log to v2 config stubs (envoyproxy#6499)
  remove idle timeout validation (envoyproxy#6500)
  build: Change namespace of chromium_url. (envoyproxy#6506)
  coverage: exclude chromium_url (envoyproxy#6498)
  fix(tracing): allow 256 chars in path tag (envoyproxy#6492)
  Common: Introduce StopAllIteration filter status for decoding and encoding filters (envoyproxy#5954)
  build: update PGV url (envoyproxy#6495)
  subset lb: avoid partitioning host lists on worker threads (envoyproxy#6302)
  ci: Make envoy_select_quiche no-op. (envoyproxy#6393)
  watcher: notify when watched files are modified (envoyproxy#6215)
  stat: Add counterFromStatName(), gaugeFromStatName(), and histogramFromStatName() (envoyproxy#6475)
  bump to 1.11.0-dev (envoyproxy#6490)
  release: bump to 1.10.0 (envoyproxy#6489)
  hcm: path normalization. (#1)
  build: import manually minified Chrome URL lib. (envoyproxy#3)
  codec: reject embedded NUL in headers. (envoyproxy#2)
  Added veryfication if path contains query params and add them to path header (envoyproxy#6466)
  redis: basic integration test for redis_proxy (envoyproxy#6450)
  stats: report sample count as an integer to prevent loss of precision (envoyproxy#6274)
  Added VHDS protobuf message and updated RouteConfig to include it. (envoyproxy#6418)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
@derekargueta derekargueta deleted the dereka/router-upstream-log-test branch June 28, 2019 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants