fix(tracing): allow 256 chars in path tag#6492
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Apr 6, 2019
Merged
fix(tracing): allow 256 chars in path tag#6492mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com>
mattklein123
approved these changes
Apr 5, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
I don't recall the history here but seems fine. @objectiser any objections?
Contributor
|
No objections |
Contributor
|
As you are changing this code, could you change to |
Member
I'm pretty sure the optimizer will do the same thing either way. |
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Apr 8, 2019
* master: (137 commits) test: router upstream log to v2 config stubs (envoyproxy#6499) remove idle timeout validation (envoyproxy#6500) build: Change namespace of chromium_url. (envoyproxy#6506) coverage: exclude chromium_url (envoyproxy#6498) fix(tracing): allow 256 chars in path tag (envoyproxy#6492) Common: Introduce StopAllIteration filter status for decoding and encoding filters (envoyproxy#5954) build: update PGV url (envoyproxy#6495) subset lb: avoid partitioning host lists on worker threads (envoyproxy#6302) ci: Make envoy_select_quiche no-op. (envoyproxy#6393) watcher: notify when watched files are modified (envoyproxy#6215) stat: Add counterFromStatName(), gaugeFromStatName(), and histogramFromStatName() (envoyproxy#6475) bump to 1.11.0-dev (envoyproxy#6490) release: bump to 1.10.0 (envoyproxy#6489) hcm: path normalization. (#1) build: import manually minified Chrome URL lib. (envoyproxy#3) codec: reject embedded NUL in headers. (envoyproxy#2) Added veryfication if path contains query params and add them to path header (envoyproxy#6466) redis: basic integration test for redis_proxy (envoyproxy#6450) stats: report sample count as an integer to prevent loss of precision (envoyproxy#6274) Added VHDS protobuf message and updated RouteConfig to include it. (envoyproxy#6418) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Increases the
max_path_lengthfor the:pathtag in tracing to 256. This returns the length to the capacity that was supported before #444 . The issue of truncating the path has been raised in a few places recently, most notably in: istio/istio#12561.I inquired as to the reasoning behind the switch to 128 from 256, but did not receive an answer. If there are valid reasons to keep 128, I would appreciate feedback there.
Risk Level: Low
Testing: Unit testing
Docs Changes: N/A
Release Notes: N/A
cc: @Stono @objectiser
Signed-off-by: Douglas Reid douglas-reid@users.noreply.github.com