redis: basic integration test for redis_proxy#6450
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Apr 4, 2019
Merged
redis: basic integration test for redis_proxy#6450mattklein123 merged 4 commits intoenvoyproxy:masterfrom
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
Conversation
- added a basic integration test for redis_proxy that sends a basic request and response between "client" and "server", and another that sends an invalid request (and receives the appropriate error in response) - plumbed bazel size option through envoy_cc_test() definition (optional, default is "medium") so tests can avoid timeout warnings; redis_proxy test set to size "small" Signed-off-by: Mitch Sukalski <mitch.sukalski@workday.com>
Contributor
Author
|
@maximebedard, @HenryYYang, @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg, and @mattklein123 here's the basic redis integration test, as promised. |
Contributor
|
Tested locally with the problematic branch: $ git checkout msukalski/redis-integration-test
$ bazel test //test/integration:redis_proxy_integration_test
# ...
INFO: Build completed successfully, 1984 total actions
//test/integration:redis_proxy_integration_test PASSED in 0.5s
$ git merge redis-prefixed-key-routing-take-2 # original branch + fix
$ bazel test //test/integration:redis_proxy_integration_test
# ...
INFO: Build completed successfully, 166 total actions
//test/integration:redis_proxy_integration_test PASSED in 0.5s
$ git revert 41d9b4dd0de4cf1c6d4d2cdf12da8998dbddad03 # commit that fixes the segfault we had last week
# ...
INFO: Build completed, 1 test FAILED, 2 total actions
//test/integration:redis_proxy_integration_test FAILED in 0.3s |
Member
|
@HenryYYang @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg please take first pass. |
Contributor
|
Just a though, maybe it's better to not take a dependency on the encoder and decoder in the integration test. If we use the raw request/response strings here, we can catch the bugs in the encoder/decoder also. |
Member
+1, I think given how simple the text protocol is might be worth doing it this way. |
Contributor
|
+1 on Henry's comment. I would prefer to keep this as stripped down as possible and treat our redis code as a black box. |
Signed-off-by: Mitch Sukalski <mitch.sukalski@workday.com>
Contributor
Author
|
@mattklein123 , @FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg , and @HenryYYang -- the test is now stripped down. |
mattklein123
requested changes
Apr 2, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thatnks a TON for adding this. A few small comments. Yay!
/wait
Signed-off-by: Mitch Sukalski <mitch.sukalski@workday.com>
mattklein123
previously approved these changes
Apr 3, 2019
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Amazing! Thank you so much this is going to be super helpful for trusting all the changes we are adding now.
mattklein123
reviewed
Apr 3, 2019
Signed-off-by: Mitch Sukalski <mitch.sukalski@workday.com>
Contributor
Author
|
You're welcome! |
msukalski
added a commit
to HenryYYang/envoy
that referenced
this pull request
Apr 6, 2019
- augmented the redis_proxy integration test for numerous positive and negative redirection scenarios - fixed ConfigHelper constructor for proper IPv4 and IPv4 address modification when multiple hosts or endpoints are defined - fixed ClientImpl::onRespValue() logic - address all sort of review feedback Signed-off-by: Mitch Sukalski <mitch.sukalski@workday.com>
msukalski
added a commit
to HenryYYang/envoy
that referenced
this pull request
Apr 6, 2019
Signed-off-by: Mitch Sukalski <mitch.sukalski@workday.com>
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Apr 8, 2019
* master: (137 commits) test: router upstream log to v2 config stubs (envoyproxy#6499) remove idle timeout validation (envoyproxy#6500) build: Change namespace of chromium_url. (envoyproxy#6506) coverage: exclude chromium_url (envoyproxy#6498) fix(tracing): allow 256 chars in path tag (envoyproxy#6492) Common: Introduce StopAllIteration filter status for decoding and encoding filters (envoyproxy#5954) build: update PGV url (envoyproxy#6495) subset lb: avoid partitioning host lists on worker threads (envoyproxy#6302) ci: Make envoy_select_quiche no-op. (envoyproxy#6393) watcher: notify when watched files are modified (envoyproxy#6215) stat: Add counterFromStatName(), gaugeFromStatName(), and histogramFromStatName() (envoyproxy#6475) bump to 1.11.0-dev (envoyproxy#6490) release: bump to 1.10.0 (envoyproxy#6489) hcm: path normalization. (#1) build: import manually minified Chrome URL lib. (envoyproxy#3) codec: reject embedded NUL in headers. (envoyproxy#2) Added veryfication if path contains query params and add them to path header (envoyproxy#6466) redis: basic integration test for redis_proxy (envoyproxy#6450) stats: report sample count as an integer to prevent loss of precision (envoyproxy#6274) Added VHDS protobuf message and updated RouteConfig to include it. (envoyproxy#6418) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a basic integration test for redis_proxy that sends
a basic request and response between "client" and "server",
and another that sends an invalid request (and receives the
appropriate error in response)
plumbed bazel size option through envoy_cc_test() definition
(optional, default is "medium" as per bazel specification) so tests
can avoid timeout warnings; redis_proxy test set to size "small"
Signed-off-by: Mitch Sukalski mitch.sukalski@workday.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
added a basic integration test for redis_proxy that sends
a basic request and response between "client" and "server",
and another that sends an invalid request (and receives the
appropriate error in response)
Risk Level: low
Testing: new integration test
Docs Changes: none
Release Notes: none
[Optional Fixes #Issue]
[Optional Deprecated:]