Skip to content

Implement QuicStringUtils and QuicStrCat#5797

Merged
mattklein123 merged 5 commits intoenvoyproxy:masterfrom
danzh2010:newplatform2
Feb 3, 2019
Merged

Implement QuicStringUtils and QuicStrCat#5797
mattklein123 merged 5 commits intoenvoyproxy:masterfrom
danzh2010:newplatform2

Conversation

@danzh2010
Copy link
Contributor

Add implementations for above 2 platform API's.
Risk Level: Low, not in use
Testing: Added test target @com_googlesource_quiche//:quic_platform_test.
Docs Changes:
Release Notes:
Part of #2557

Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
alyssawilk
alyssawilk previously approved these changes Jan 31, 2019
@alyssawilk alyssawilk self-assigned this Jan 31, 2019
mpwarres
mpwarres previously approved these changes Feb 1, 2019
Copy link
Contributor

@mpwarres mpwarres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
@danzh2010 danzh2010 dismissed stale reviews from mpwarres and alyssawilk via 5555bf1 February 1, 2019 20:52
@danzh2010
Copy link
Contributor Author

made some dependency changes according to #5801. PTAL!

Copy link
Contributor

@mpwarres mpwarres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattklein123 mattklein123 merged commit e8411b0 into envoyproxy:master Feb 3, 2019
fredlas pushed a commit to fredlas/envoy that referenced this pull request Mar 5, 2019
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Fred Douglas <fredlas@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants