Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions bazel/external/quiche.BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ licenses(["notice"]) # Apache 2
# should remain largely the same.

load(":genrule_cmd.bzl", "genrule_cmd")
load(
"@envoy//bazel:envoy_build_system.bzl",
"envoy_cc_test",
)

src_files = glob([
"**/*.h",
Expand Down Expand Up @@ -118,9 +122,11 @@ cc_library(
"quiche/quic/platform/api/quic_flag_utils.h",
"quiche/quic/platform/api/quic_iovec.h",
"quiche/quic/platform/api/quic_prefetch.h",
"quiche/quic/platform/api/quic_ptr_util.h",
"quiche/quic/platform/api/quic_str_cat.h",
"quiche/quic/platform/api/quic_string.h",
"quiche/quic/platform/api/quic_string_piece.h",
"quiche/quic/platform/api/quic_ptr_util.h",
"quiche/quic/platform/api/quic_string_utils.h",
"quiche/quic/platform/api/quic_uint128.h",
# TODO: uncomment the following files as implementations are added.
# "quiche/quic/platform/api/quic_bug_tracker.h",
Expand Down Expand Up @@ -150,8 +156,6 @@ cc_library(
# "quiche/quic/platform/api/quic_sleep.h",
# "quiche/quic/platform/api/quic_socket_address.h",
# "quiche/quic/platform/api/quic_stack_trace.h",
# "quiche/quic/platform/api/quic_str_cat.h",
# "quiche/quic/platform/api/quic_string_utils.h",
# "quiche/quic/platform/api/quic_test.h",
# "quiche/quic/platform/api/quic_test_loopback.h",
# "quiche/quic/platform/api/quic_test_mem_slice_vector.h",
Expand All @@ -164,3 +168,12 @@ cc_library(
"@envoy//source/extensions/quic_listeners/quiche/platform:quic_platform_base_impl_lib",
],
)

envoy_cc_test(
name = "quic_platform_test",
srcs = ["quiche/quic/platform/api/quic_string_utils_test.cc"],
repository = "@envoy",
deps = [
":quic_platform",
],
)
2 changes: 2 additions & 0 deletions source/extensions/quic_listeners/quiche/platform/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ envoy_cc_library(
name = "quic_platform_impl_lib",
hdrs = [
"quic_mutex_impl.h",
"quic_str_cat_impl.h",
"quic_string_utils_impl.h",
],
external_deps = [
"quiche_quic_platform_base",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
#pragma once

#include "absl/strings/str_cat.h"
#include "fmt/printf.h"
#include "quiche/quic/platform/api/quic_string.h"

// NOLINT(namespace-envoy)

// This file is part of the QUICHE platform implementation, and is not to be
// consumed or referenced directly by other Envoy code. It serves purely as a
// porting layer for QUICHE.

namespace quic {

template <typename... Args> inline QuicString QuicStrCatImpl(const Args&... args) {
return absl::StrCat(args...);
}

template <typename... Args> inline QuicString QuicStringPrintfImpl(const Args&... args) {
return fmt::sprintf(std::forward<const Args&>(args)...);
}

} // namespace quic
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
#pragma once

#include "absl/strings/str_cat.h"
#include "quiche/quic/platform/api/quic_string.h"

// NOLINT(namespace-envoy)

// This file is part of the QUICHE platform implementation, and is not to be
// consumed or referenced directly by other Envoy code. It serves purely as a
// porting layer for QUICHE.

namespace quic {

template <typename... Args> inline void QuicStrAppendImpl(QuicString* output, const Args&... args) {
absl::StrAppend(output, args...);
}

} // namespace quic