Merged
Conversation
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Contributor
Author
|
/assign @mpwarres |
mpwarres
previously approved these changes
Feb 1, 2019
Contributor
mpwarres
left a comment
mpwarres
left a comment
There was a problem hiding this comment.
LGTM, with one optional comment. Thanks!
|
|
||
| cc_library( | ||
| name = "quic_platform", | ||
| srcs = ["quiche/quic/platform/api/quic_mutex.cc"], |
Contributor
There was a problem hiding this comment.
Nice, splitting targets makes sense to deal with the impl -> api dependency. I wouldn't be surprised if we have to do this for a few more targets, which may require some shuffling in naming, but we can deal with that if/when we need to.
|
|
||
| namespace quic { | ||
|
|
||
| void QuicLockImpl::WriterLock() { mu_.WriterLock(); } |
Contributor
There was a problem hiding this comment.
Since all the method definitions are trivial, could they be inlined in the .h file, and then there's no need for the .cc file?
Contributor
Author
|
/assign @mattklein123 |
mattklein123
approved these changes
Feb 1, 2019
fredlas
pushed a commit
to fredlas/envoy
that referenced
this pull request
Mar 5, 2019
Signed-off-by: Dan Zhang <danzh@google.com> Signed-off-by: Fred Douglas <fredlas@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add quic_mutex_impl.* and test.
Update envoy to refer to new tarball dc5ce1a82e342bfd366a1ccdf2a2717edb46e4ec.tar.gz which fix #include rules in quic_mutex.h.
Move some API's from external target quic_platform into quic_platform_base, so that those API's can be depended on by other impl target. Otherwise there would be a dependency circle when impl depends on other quic API's.
Risk Level: low, not in use
Part of #2557