Increase code coverage in conn_manager_impl#417
Merged
RomanDzhabarov merged 3 commits intomasterfrom Feb 6, 2017
Merged
Conversation
mattklein123
reviewed
Feb 3, 2017
| Buffer::OwnedImpl fake_input("1234"); | ||
| conn_manager_->onData(fake_input); | ||
|
|
||
| // Make destruction of active stream so that we can capture tracing HC stat. |
| break; | ||
| case Tracing::Reason::HealthCheck: | ||
| connection_manager_.config_.tracingStats().health_check_.inc(); | ||
| // At this point we have not run any filters, including HC one, so this should not happen. |
Member
There was a problem hiding this comment.
then take this case statement out, add a default, and throw an invalid argument exception to crash (and add test to that effect).
Member
Author
There was a problem hiding this comment.
sounds good, need to rearrange stuff a little bit for this, should be easy
mattklein123
approved these changes
Feb 5, 2017
zuercher
pushed a commit
that referenced
this pull request
Jan 23, 2018
…#2387) Description: Extend the health check filter to optionally compute its HTTP response status based on whether at least a specified percentage of servers in a specified set of upstream clusters are healthy. Risk Level: Medium Testing: Unit tests included Docs Changes: #425 Release Notes: Included in this PR Fixes: #2362 API Changes: #417 Signed-off-by: Brian Pane bpane@pinterest.com
rshriram
added a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* Revert "envoy sha update (envoyproxy#414)" This reverts commit ebb5ef1. * Revert "Fix mixer forward attribute bug. (envoyproxy#412)" This reverts commit 4f07917.
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of mixerclient This PR will be merged automatically once checks are successful. ```release-note none ```
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Updates the standard configuration to send requests over HTTP/2 by default. Note that there are future improvements that should be made here to support negotiating between HTTP/1.1 and HTTP/2, being tracked in envoyproxy/envoy-mobile#502. More info on the config change: https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/cds.proto#envoy-api-msg-cluster Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Updates the standard configuration to send requests over HTTP/2 by default. Note that there are future improvements that should be made here to support negotiating between HTTP/1.1 and HTTP/2, being tracked in envoyproxy/envoy-mobile#502. More info on the config change: https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/cds.proto#envoy-api-msg-cluster Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Commit Message** Previously, router instance shared the rng among multiple goroutines which is not a thread safe. This fixes it by having a goroutine local RNG. **Related Issues/PRs (if applicable)** Contributes to #53 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
+add proper HC stats on tracing.
@lyft/network-team