Change types to not assume an arch#425
Merged
Reflejo merged 1 commit intoenvoyproxy:masterfrom Feb 6, 2017
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of these types were assuming that
size_t == uint64_tor thatuint64_t == unsigned longbut that's not universally true, some BSDs such as Darwin define uint64_t as unsigned long long which warns on literals that are defined asUL.Additionally there was also some assumptions made on the pch as to forward declaration. So I explicitly added some needed ones.