response decoder: Roll forward ResponseDecoderHandle#41193
Merged
danzh2010 merged 7 commits intoenvoyproxy:mainfrom Sep 26, 2025
Merged
response decoder: Roll forward ResponseDecoderHandle#41193danzh2010 merged 7 commits intoenvoyproxy:mainfrom
danzh2010 merged 7 commits intoenvoyproxy:mainfrom
Conversation
…of response decoder (envoyproxy#41048)" This reverts commit bfd5b10. Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
danzh2010
requested review from
RyanTheOptimist,
abeyad,
agrawroh,
botengyao,
mattklein123,
yanavlasov and
zuercher
as code owners
danzh2010
changed the title
Contributor
Author
|
/retest |
Contributor
Author
|
/assign @RyanTheOptimist @abeyad |
abeyad
previously approved these changes
Sep 23, 2025
| namespace Envoy { | ||
| namespace Router { | ||
|
|
||
| class UpstreamToDownstreamImplBase : public UpstreamToDownstream { |
Contributor
There was a problem hiding this comment.
Just FYI, I think we'll have to update some Google-specific (internal) classes with this change.
| EXPECT_EQ(0u, quic_session_.bytesToSend()); | ||
| } | ||
|
|
||
| TEST_F(EnvoyQuicClientStreamTest, DecoderDestroyedBeforeDecoding1xxHeader) { |
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Contributor
Author
|
/retest |
Signed-off-by: Dan Zhang <danzh@google.com>
Signed-off-by: Dan Zhang <danzh@google.com>
Contributor
Author
|
/retest |
Contributor
Author
|
I've address the test coverage issue. PTAL again! |
eric846
pushed a commit
to envoyproxy/nighthawk
that referenced
this pull request
Oct 1, 2025
- Update the ENVOY_COMMIT and ENVOY_SHA in bazel/repositories.bzl to the latest Envoy's commit. - Update .bazelrc to envoyproxy/envoy#40908 - Update tools/code_format/config.yaml to envoyproxy/envoy#41148 - Changes to support envoyproxy/envoy#41193 Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Reapply "response decoder: add new interfaces for life time tracking of response decoder (#41048)"
Additional Description: In addition to changes in #41048, this PR added a new constructor to ResponseDecoderWrapper to take a ResponseDecoderHandle to avoid accessing the decode object at anytime without checking its liveliness. It also changes ConnectivityGrid and HttpConnPoolImplBase to retain an ResponseDecoderHandle rather than directly referencing to ResponseDecoder during the async connection establishment.
Added a regression test for the crash observed with the previous change.
Risk Level: medium
Testing: new integration tests
Docs Changes: N/A
Release Notes: Y
Platform Specific Features: N/A
Runtime guard: envoy.reloadable_features.use_response_decoder_handle default true and envoy.reloadable_features.abort_when_accessing_dead_decoder default false