Add HttpCache version 2#41148
Conversation
Signed-off-by: Raven Black <ravenblack@dropbox.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
For anyone who wasn't following along, #37990 became embroiled in an impossible conflict of "we can't have this because it adds some ugly API that we should remove later but we can't remove API fields from a non-WIP API" and "it can't work without either the ugly API or a huge risky core change to envoy". The agreed compromise was to make it a new filter, still tagged WIP, so the ugly API can be removed if the roadblocks are ever addressed. The old cache filter at this point has no maintainer sponsor (though I'm still on there for now), meaning it will eventually need to move into contrib or be removed entirely. |
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
|
/coverage |
|
Coverage for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-cncf-pr/41148/coverage/index.html For comparison, current coverage on https://storage.googleapis.com/envoy-cncf-postsubmit/main/coverage/index.html The coverage results are (re-)rendered each time the CI |
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
… header validation consistent. Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
|
/retest |
|
The original #37990 was reviwed by @toddmgreer . I'll do a second pass . |
- Update the ENVOY_COMMIT and ENVOY_SHA in bazel/repositories.bzl to the latest Envoy's commit. - Update .bazelrc to envoyproxy/envoy#40908 - Update tools/code_format/config.yaml to envoyproxy/envoy#41148 - Changes to support envoyproxy/envoy#41193 Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Commit Message: remove ravenblackx from deprecated cache ownership Additional Description: With #41148 introducing a new cache filter implementation that expects to be maintained, it no longer makes sense to accept PRs touching the deprecated filter (other than to more firmly deprecate it or move it to contrib where it doesn't need a maintainer). Giving it the UNOWNED property is a gentle step towards making this clearer, and signifying my intent to not review any PRs that aim to "upkeep" the deprecated cache filter. --------- Signed-off-by: Raven Black <ravenblack@dropbox.com>
Commit Message: Add HttpCache version 2
Additional Description: This is essentially just moving #37990 into a new namespace. In addition to simple renames, some factory functions were changed from using throw to returning StatusOr,
allowed_vary_headerswas hidden as not implemented, and the whole API was tagged WIP as the old version always should have been. There was also a side-effect that the protobuf stableHashKey value for a given cache entry changed because the proto message full-names changed; I bumped the file system cache version so that pre-existing cache entries will be invalidated.From #37990 the improved features of this new cache implementation are:
varyheaders are unsupported temporarily, rather than broken-supported as they were before.And the big dubious feature is:
Risk Level: Very low since it doesn't change existing APIs and only adds a WIP no-security-posture filter, don't use it!
Testing: Loads.
Docs Changes: Mostly-duplicate docs for the new version.
Release Notes: Follow shortly.
Platform Specific Features: No windows support for file system cache, same as before.