Skip to content

fmtlib: align BUILD files with their BCR definitions#40908

Merged
phlax merged 2 commits intoenvoyproxy:mainfrom
mmorel-35:external-builds
Sep 23, 2025
Merged

fmtlib: align BUILD files with their BCR definitions#40908
phlax merged 2 commits intoenvoyproxy:mainfrom
mmorel-35:external-builds

Conversation

@mmorel-35
Copy link
Copy Markdown
Contributor

@mmorel-35 mmorel-35 commented Sep 1, 2025

Commit Message: fmtlib: align BUILD files with their BCR definitions
Additional Description:

This is aligning BUILD files with their actual content in publicated modules in BCR, update the associated dependencies

It is related to #40692

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #40908 was opened by mmorel-35.

see: more, trace.

@mmorel-35 mmorel-35 changed the title replace fmtlib references and adjust dependencies align BUILD files with their BCR definitions Sep 1, 2025
@mmorel-35 mmorel-35 force-pushed the external-builds branch 2 times, most recently from 24af0e7 to 5069672 Compare September 1, 2025 07:39
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Sep 1, 2025
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @agrawroh

🐱

Caused by: #40908 was synchronize by mmorel-35.

see: more, trace.

@mmorel-35 mmorel-35 force-pushed the external-builds branch 5 times, most recently from caee47c to 491cf4e Compare September 1, 2025 11:13
@mmorel-35 mmorel-35 changed the title align BUILD files with their BCR definitions fmtlib: align BUILD files with their BCR definitions Sep 1, 2025
@mmorel-35 mmorel-35 force-pushed the external-builds branch 2 times, most recently from 29f40a7 to 75174b8 Compare September 1, 2025 11:22
@mmorel-35 mmorel-35 marked this pull request as ready for review September 1, 2025 16:27
@phlax phlax self-assigned this Sep 1, 2025
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mmorel-35

@phlax phlax merged commit b6aa789 into envoyproxy:main Sep 23, 2025
28 checks passed
@mmorel-35 mmorel-35 deleted the external-builds branch September 23, 2025 14:15
lucaschimweg pushed a commit to lucaschimweg/envoy that referenced this pull request Sep 23, 2025
Commit Message: fmtlib: align BUILD files with their BCR definitions
Additional Description:

This is aligning BUILD files with their actual content in publicated
modules in BCR, update the associated dependencies

It is related to envoyproxy#40692

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
eric846 pushed a commit to envoyproxy/nighthawk that referenced this pull request Oct 1, 2025
- Update the ENVOY_COMMIT and ENVOY_SHA in bazel/repositories.bzl to the latest Envoy's commit.
- Update .bazelrc to envoyproxy/envoy#40908
- Update tools/code_format/config.yaml to envoyproxy/envoy#41148
- Changes to support envoyproxy/envoy#41193

Signed-off-by: tomjzzhang <4367421+tomjzzhang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps Approval required for changes to Envoy's external dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants