Support drop_overload API#30827
Merged
yanavlasov merged 21 commits intoenvoyproxy:mainfrom Dec 8, 2023
Merged
Conversation
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Contributor
Author
|
/assign @yanavlasov @vishalpowar @adisuissa @KBaichoo |
markdroth
reviewed
Nov 28, 2023
adisuissa
reviewed
Nov 28, 2023
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Thanks for working on this!
Here's a first pass.
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
KBaichoo
reviewed
Nov 28, 2023
yanavlasov
requested changes
Nov 28, 2023
markdroth
reviewed
Nov 28, 2023
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
…overload Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Contributor
|
/lgtm api |
KBaichoo
reviewed
Dec 4, 2023
Contributor
KBaichoo
left a comment
KBaichoo
left a comment
There was a problem hiding this comment.
Looks good apart from outstanding comments. Thank you.
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
yanavlasov
requested changes
Dec 5, 2023
Contributor
yanavlasov
left a comment
yanavlasov
left a comment
There was a problem hiding this comment.
Looks very good. Thanks. I just have one more suggestion and it is ready to be submitted.
/wait
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Contributor
Author
|
/retest |
adisuissa
approved these changes
Dec 6, 2023
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
LGTM, thanks!
/assign-from @envoyproxy/senior-maintainers
|
@envoyproxy/senior-maintainers assignee is @yanavlasov |
Contributor
Author
|
Kind ping! |
yanavlasov
approved these changes
Dec 8, 2023
yanavlasov
pushed a commit
that referenced
this pull request
Mar 4, 2025
…38408) This is a follow up commit of drop_overload support:#30827. It is observed that in some situations, EDS sends drop_overload ratio as 100% for some clusters do not have healthy endpoints in the cluster. For such cases, it is preferred that the RCD of the local reply set to "unconditional drop overload" to make it a little bit different from the normal "drop overload" case. --------- Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
update-envoy bot
added a commit
to envoyproxy/data-plane-api
that referenced
this pull request
Mar 4, 2025
…38408) This is a follow up commit of drop_overload support:envoyproxy/envoy#30827. It is observed that in some situations, EDS sends drop_overload ratio as 100% for some clusters do not have healthy endpoints in the cluster. For such cases, it is preferred that the RCD of the local reply set to "unconditional drop overload" to make it a little bit different from the normal "drop overload" case. --------- Signed-off-by: Yanjun Xiang <yanjunxiang@google.com> Mirrored from https://github.com/envoyproxy/envoy @ 5ff9f03e3af26fad5fd444a4a166c7d8d9b44ffc
phlax
pushed a commit
to phlax/envoy-openssl
that referenced
this pull request
Mar 7, 2025
…38408) This is a follow up commit of drop_overload support:envoyproxy/envoy#30827. It is observed that in some situations, EDS sends drop_overload ratio as 100% for some clusters do not have healthy endpoints in the cluster. For such cases, it is preferred that the RCD of the local reply set to "unconditional drop overload" to make it a little bit different from the normal "drop overload" case. --------- Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
jewertow
pushed a commit
to jewertow/envoy
that referenced
this pull request
Apr 2, 2025
…nvoyproxy#38408) This is a follow up commit of drop_overload support:envoyproxy#30827. It is observed that in some situations, EDS sends drop_overload ratio as 100% for some clusters do not have healthy endpoints in the cluster. For such cases, it is preferred that the RCD of the local reply set to "unconditional drop overload" to make it a little bit different from the normal "drop overload" case. --------- Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
agrawroh
pushed a commit
to agrawroh/envoy
that referenced
this pull request
Apr 9, 2025
…nvoyproxy#38408) This is a follow up commit of drop_overload support:envoyproxy#30827. It is observed that in some situations, EDS sends drop_overload ratio as 100% for some clusters do not have healthy endpoints in the cluster. For such cases, it is preferred that the RCD of the local reply set to "unconditional drop overload" to make it a little bit different from the normal "drop overload" case. --------- Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implement envoy drop_overload support as in:
#3823
For Envoy, it is decided to only support one category at this moment. So, the implementation has size check for drop_overloads configuration.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]