Sending local reply with status code 502 for request dropped by drop_overload#31681
Closed
yanjunxiang-google wants to merge 1 commit intoenvoyproxy:mainfrom
Closed
Sending local reply with status code 502 for request dropped by drop_overload#31681yanjunxiang-google wants to merge 1 commit intoenvoyproxy:mainfrom
yanjunxiang-google wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
…ropped by DROP_OVERLOAD Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
yanjunxiang-google
changed the title
yanjunxiang-google
changed the title
Contributor
Author
|
This is a follow up commit for #30827. |
Contributor
Author
|
/assign @adisuissa @yanavlasov |
adisuissa
reviewed
Jan 8, 2024
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Thanks!
Left a high-level question.
/wait-any
adisuissa
reviewed
Jan 8, 2024
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
sorry, forgot to press the "start review" button
| ENVOY_STREAM_LOG(debug, "The request is dropped by DROP_OVERLOAD", *callbacks_); | ||
| callbacks_->streamInfo().setResponseFlag(StreamInfo::ResponseFlag::DropOverLoad); | ||
| chargeUpstreamCode(Http::Code::ServiceUnavailable, nullptr, true); | ||
| chargeUpstreamCode(Http::Code::BadGateway, nullptr, true); |
Contributor
There was a problem hiding this comment.
According to the RFC 503 definition of 503:
... indicates that the server is currently unable to handle the request due to a temporary overload or scheduled maintenance, which will likely be alleviated after some delay.
which seems like a better fit, no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending local reply with status code 502 (BAD_GATEWAY) instead of 503(SERVICE_UNAVAILABLE)for request dropped by drop_overload.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]