Set RCD for 100% drop_overload case as unconditional_drop_overload#38408
Merged
yanavlasov merged 9 commits intoenvoyproxy:mainfrom Mar 4, 2025
Merged
Set RCD for 100% drop_overload case as unconditional_drop_overload#38408yanavlasov merged 9 commits intoenvoyproxy:mainfrom
yanavlasov merged 9 commits intoenvoyproxy:mainfrom
Conversation
…and LoadShed check Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
yanjunxiang-google
changed the title
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
yanjunxiang-google
changed the title
Contributor
Author
| tested drop_overload = 100% case. |
Contributor
Author
|
/assign @yanavlasov @yurykats |
Contributor
Author
|
/retest |
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
…drop_overload Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Contributor
Author
|
/assign @markdroth |
Contributor
Are there any tests that validate different reason codes for drop overload cases? /wait-any |
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Contributor
Author
Added |
yanavlasov
approved these changes
Mar 4, 2025
jewertow
pushed a commit
to jewertow/envoy
that referenced
this pull request
Apr 2, 2025
…nvoyproxy#38408) This is a follow up commit of drop_overload support:envoyproxy#30827. It is observed that in some situations, EDS sends drop_overload ratio as 100% for some clusters do not have healthy endpoints in the cluster. For such cases, it is preferred that the RCD of the local reply set to "unconditional drop overload" to make it a little bit different from the normal "drop overload" case. --------- Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
agrawroh
pushed a commit
to agrawroh/envoy
that referenced
this pull request
Apr 9, 2025
…nvoyproxy#38408) This is a follow up commit of drop_overload support:envoyproxy#30827. It is observed that in some situations, EDS sends drop_overload ratio as 100% for some clusters do not have healthy endpoints in the cluster. For such cases, it is preferred that the RCD of the local reply set to "unconditional drop overload" to make it a little bit different from the normal "drop overload" case. --------- Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up commit of drop_overload support:#30827.
It is observed that in some situations, EDS sends drop_overload ratio as 100% for some clusters do not have healthy endpoints in the cluster. For such cases, it is preferred that the RCD of the local reply set to "unconditional drop overload" to make it a little bit different from the normal "drop overload" case.