grpc_stats: removed runtime feature after deprecation period#28144
Merged
jmarantz merged 2 commits intoenvoyproxy:mainfrom Jul 13, 2023
Merged
grpc_stats: removed runtime feature after deprecation period#28144jmarantz merged 2 commits intoenvoyproxy:mainfrom
jmarantz merged 2 commits intoenvoyproxy:mainfrom
Conversation
Removing `envoy.deprecated_features.grpc_stats_filter_enable_stats_for_all_methods_by_default` which has been deprecated since 2021. Signed-off-by: Greg Greenway <ggreenway@apple.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Member
Author
|
This has been deprecated since #14815 but somehow removing the old codepath was missed. |
Member
Author
|
/retest |
Member
Author
|
/assign-from @envoyproxy/envoy-maintainers |
|
@envoyproxy/envoy-maintainers assignee is @lizan |
Contributor
|
@lizan ping! |
Member
Author
|
/assign-from @envoyproxy/envoy-maintainers |
|
@envoyproxy/envoy-maintainers assignee is @jmarantz |
jmarantz
approved these changes
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Removing
envoy.deprecated_features.grpc_stats_filter_enable_stats_for_all_methods_by_defaultwhich has been deprecated since 2021.Additional Description:
Risk Level: low
Testing: existing unit tests
Docs Changes: docs update
Release Notes: added
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]