grpc_stats: switch default of stats_for_all_methods#14815
Merged
ggreenway merged 2 commits intoenvoyproxy:mainfrom Jan 26, 2021
Merged
grpc_stats: switch default of stats_for_all_methods#14815ggreenway merged 2 commits intoenvoyproxy:mainfrom
stats_for_all_methods#14815ggreenway merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Greg Greenway <ggreenway@apple.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Greg Greenway <ggreenway@apple.com>
lizan
approved these changes
Jan 26, 2021
Member
|
/lgtm v2-freeze |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Greg Greenway ggreenway@apple.com
Commit Message: grpc_stats: switch default of
stats_for_all_methodsAdditional Description: This change was announced (and previous value deprecated) in v1.14.0 (#10467).
Risk Level: Low
Testing: Adjusted unittests
Docs Changes: Updated
Release Notes: Added
Platform Specific Features: None
Optional Runtime guard:
envoy.deprecated_features.grpc_stats_filter_enable_stats_for_all_methods_by_default[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]