Revert "logging: Assert fail on pthread without log lock"#2629
Closed
lita wants to merge 7 commits intoenvoyproxy:masterfrom
Closed
Revert "logging: Assert fail on pthread without log lock"#2629lita wants to merge 7 commits intoenvoyproxy:masterfrom
lita wants to merge 7 commits intoenvoyproxy:masterfrom
Conversation
added 7 commits
February 15, 2018 14:24
…o avoid initiating multiple regexes that don't match. (envoyproxy#2582)" This reverts commit 9c728a0.
This reverts commit 02c34e0.
…gging before validation (envoyproxy#2623)" This reverts commit 89b1ea6.
…nitialized logging. (envoyproxy#2619)" This reverts commit 98fe3e8.
Member
|
@lita can you expand on the rationale for the rollback? Preferably in the commit message at top. |
Contributor
|
My bad - wrong pr to revert. Closing |
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
* Add TCP Metrics in Istio 1.5 similar to Istio 1.4 Fix wasm_proxy test Add timer based TCP metrics Fix lint err Fix lint err Regenerate WASM file Remove locks as WASM is single threaded Add plugin.wasm Fixed based on feedback Fixed err Regen wasm file Fixed based on feedback Adding wasm file fix lint err * fix based on feedback * Update wasm files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2619