thread: annotation support when !OS X.

STYLE.md

@@ -63,6 +63,10 @@
   NiceMock for mocks whose behavior is not the focus of a test.
 * There are probably a few other things missing from this list. We will add them as they
   are brought to our attention.
+* [Thread
+  annotations](https://github.com/abseil/abseil-cpp/blob/master/absl/base/thread_annotations.h),
+  such as `GUARDED_BY`, should be used for shared state guarded by
+  locks/mutexes.
 
 # Error handling
 

source/common/common/BUILD

@@ -109,6 +109,12 @@ envoy_cc_library(
     hdrs = ["stl_helpers.h"],
 )
 
+envoy_cc_library(
+    name = "thread_annotations",
+    hdrs = ["thread_annotations.h"],
+    external_deps = ["abseil_base"],
+)
+
 envoy_cc_library(
     name = "thread_lib",
     srcs = ["thread.cc"],

source/common/common/thread_annotations.h

@@ -0,0 +1,11 @@
+#pragma once
+
+// NOLINT(namespace-envoy)
+
+#include "absl/base/thread_annotations.h"
+
+#ifdef __APPLE__
+#undef THREAD_ANNOTATION_ATTRIBUTE__
+// See #2571, we get problematic warnings on Clang + OS X.
+#define THREAD_ANNOTATION_ATTRIBUTE__(x) // no-op
+#endif

source/common/grpc/BUILD

@@ -85,6 +85,7 @@ envoy_cc_library(
         "//include/envoy/thread_local:thread_local_interface",
         "//source/common/common:empty_string",
         "//source/common/common:linked_object",
+        "//source/common/common:thread_annotations",
         "//source/common/common:thread_lib",
         "//source/common/tracing:http_tracer_lib",
     ],

source/common/grpc/google_async_client_impl.h

@@ -8,6 +8,7 @@
 
 #include "common/common/linked_object.h"
 #include "common/common/thread.h"
+#include "common/common/thread_annotations.h"
 #include "common/tracing/http_tracer_impl.h"
 
 #include "grpc++/generic/generic_stub.h"
@@ -289,7 +290,8 @@ class GoogleAsyncStreamImpl : public AsyncStream,
   uint32_t inflight_tags_{};
   // Queue of completed (op, ok) passed from completionThread() to
   // handleOpCompletion().
-  std::deque<std::pair<GoogleAsyncTag::Operation, bool>> completed_ops_;
+  std::deque<std::pair<GoogleAsyncTag::Operation, bool>>
+      completed_ops_ GUARDED_BY(completed_ops_lock_);
   std::mutex completed_ops_lock_;
 
   friend class GoogleAsyncClientImpl;