[backport/v1.23]: ci: use host docker gid for envoybuild + deps: Update ragel#23837
Merged
phlax merged 3 commits intoenvoyproxy:release/v1.23from Nov 4, 2022
Merged
[backport/v1.23]: ci: use host docker gid for envoybuild + deps: Update ragel#23837phlax merged 3 commits intoenvoyproxy:release/v1.23from
phlax merged 3 commits intoenvoyproxy:release/v1.23from
Conversation
Previously `/var/run/docker.sock` is readable/writable inside docker run because group ID of `envoygroup` coincidentally matches host docker group, while it is no longer true during rolling out new image. Fixing that by forcing `envoygroup` has host docker group ID. Cherry-picked from: 7ac5336. Signed-off-by: Lizan Zhou <lizan@tetrate.io> Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Member
|
arggh - looks like we need something else - something to do with ragel |
Member
|
might be this #22635 - altho i think that PR was more to do with licensing - worth a try |
Commit Message: deps: update Ragel Additional Description: A thread of Ragel and its license has been opened in the Slack channel today. Currently, Ragel is under GPLv2. It is legal to use Ragel as a tool to compile, but we have to compile Ragel in Envoy's building system and there is potential risk of the copyright. The patch updates Ragel to the latest version with MIT license to suppress the concern. Risk Level: Low Testing: N/A Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Xie Zhihao <zhihao.xie@intel.com> Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
repokitteh-read-only
Bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
dio
changed the title
repokitteh-read-only
Bot
removed
the
deps
Member
|
/retest |
|
Retrying Azure Pipelines: |
Member
|
/retest |
|
Retrying Azure Pipelines: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from:
Signed-off-by: Lizan Zhou lizan@tetrate.io
Signed-off-by: Xie Zhihao zhihao.xie@intel.com
Signed-off-by: Dhi Aurrahman dio@rockybars.com