deps: update Ragel by zhxie · Pull Request #22635 · envoyproxy/envoy

zhxie · 2022-08-10T03:34:12Z

Signed-off-by: Xie Zhihao zhihao.xie@intel.com

Commit Message: deps: update Ragel
Additional Description:

A thread of Ragel and its license has been opened in the Slack channel today. Currently, Ragel is under GPLv2. It is legal to use Ragel as a tool to compile, but we have to compile Ragel in Envoy's building system and there is potential risk of the copyright. The patch updates Ragel to the latest version with MIT license to suppress the concern.

Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>

repokitteh-read-only · 2022-08-10T03:34:19Z

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @htuch

🐱

Caused by: #22635 was opened by zhxie.

see: more, trace.

zhxie · 2022-08-10T03:40:58Z

CC @mattklein123

htuch · 2022-08-10T03:57:27Z

+        version = "0.14.7",
+        sha256 = "6037b31c358dda6f580f7321f97a182144a8401c690b458fcae055c65501977d",
+        strip_prefix = "colm-{version}",
+        urls = ["https://www.colm.net/files/colm/colm-{version}.tar.gz"],


Can we reference Github locations for these files? It's easier to reason about the dependency with canonical links to GH, including things like licenses.

I may take time to try to switch to the GitHub repo. Previously, the repo and the tar ball contains different files. Ragel codes from the repo require Ragel itself to compile, which is ridiculous.

Thanks @htuch. I came here to say the same thing. I've been running the following for months without issue
urls = ["https://github.com/adrian-thurston/ragel/archive/ragel-{version}.tar.gz"],
Edit: I'm not compiling in any of the Intel Hyperscan contrib extensions

Yeah, I fixed that just now, thanks.

Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>

zhxie · 2022-08-10T07:11:56Z

/retest

repokitteh-read-only · 2022-08-10T07:12:00Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #22635 (comment) was created by @zhxie.

see: more, trace.

Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>

mattklein123 · 2022-08-10T14:55:41Z

-        version = "6.10",
-        sha256 = "5f156edb65d20b856d638dd9ee2dfb43285914d9aa2b6ec779dac0270cd56c3f",
+        version = "d4577c924451b331c73c8ed0af04f6efd35ac0b4",
+        sha256 = "fa3474d50da9c870b79b51ad43f8d11cdf05268f5ec05a602ecd5b1b5f5febb0",


Can you add a comment here on why we are using this SHA vs. the release version (just about the license switch with perhaps a link to the page describing the license of this thing). Thank you.

/wait

SHA vs. the release version

The release version contains a bug to prevent building static libraries. So we have to use the latest one. I will document them, thanks.

Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>

htuch

LGTM

moderation · 2022-08-17T14:20:41Z

+    net_colm_open_source_colm = dict(
+        project_name = "Colm",
+        project_desc = "The Colm Programming Language",
+        project_url = "https://www.colm.net/open-source/colm/",
+        # The latest release version v0.14.7 prevents building statically (see
+        # https://github.com/adrian-thurston/colm/issues/146). The latest SHA includes the fix (see
+        # https://github.com/adrian-thurston/colm/commit/fc61ecb3a22b89864916ec538eaf04840e7dd6b5).
+        # TODO(zhxie): Update to the next release version when it is released.
+        version = "2d8ba76ddaf6634f285d0a81ee42d5ee77d084cf",
+        sha256 = "0399e9bef7603a8f3d94acd0b0af6b5944cc3103e586734719379d3ec09620c0",
+        strip_prefix = "colm-{version}",
+        urls = ["https://github.com/adrian-thurston/colm/archive/{version}.tar.gz"],
+        use_category = ["dataplane_ext"],
+        extensions = [
+            "envoy.matching.input_matchers.hyperscan",
+            "envoy.regex_engines.hyperscan",
+        ],
+        release_date = "2021-12-28",
+        cpe = "N/A",
+    ),


Poor results on OSSF scan

scorecard --repo=https://github.com/adrian-thurston/colm RESULTS ------- Aggregate score: 4.8 / 10 Check scores: |---------|------------------------|--------------------------------|-----------------------------------------------------------------------------------| | SCORE | NAME | REASON | DOCUMENTATION/REMEDIATION | |---------|------------------------|--------------------------------|-----------------------------------------------------------------------------------| | 10 / 10 | Binary-Artifacts | no binaries found in the repo | https://github.com/ossf/scorecard/blob/main/docs/checks.md#binary-artifacts | |---------|------------------------|--------------------------------|-----------------------------------------------------------------------------------| | 0 / 10 | Branch-Protection | branch protection not enabled | https://github.com/ossf/scorecard/blob/main/docs/checks.md#branch-protection | | | | on development/release | | | | | branches | | |---------|------------------------|--------------------------------|-----------------------------------------------------------------------------------| | 0 / 10 | CI-Tests | 0 out of 22 merged PRs | https://github.com/ossf/scorecard/blob/main/docs/checks.md#ci-tests | | | | checked by a CI test -- score | | | | | normalized to 0 | | |---------|------------------------|--------------------------------|-----------------------------------------------------------------------------------| | 0 / 10 | CII-Best-Practices | no badge detected | https://github.com/ossf/scorecard/blob/main/docs/checks.md#cii-best-practices | |---------|------------------------|--------------------------------|-----------------------------------------------------------------------------------| | 3 / 10 | Code-Review | GitHub code reviews found for | https://github.com/ossf/scorecard/blob/main/docs/checks.md#code-review | | | | 9 commits out of the last 30 | | | | | -- score normalized to 3 | | |---------|------------------------|--------------------------------|-----------------------------------------------------------------------------------| | 10 / 10 | Contributors | 13 different organizations | https://github.com/ossf/scorecard/blob/main/docs/checks.md#contributors | | | | found -- score normalized to | | | | | 10 | | |---------|------------------------|--------------------------------|-----------------------------------------------------------------------------------| | 10 / 10 | Dangerous-Workflow | no dangerous workflow patterns | https://github.com/ossf/scorecard/blob/main/docs/checks.md#dangerous-workflow | | | | detected | | |---------|------------------------|--------------------------------|-----------------------------------------------------------------------------------| | 0 / 10 | Dependency-Update-Tool | no update tool detected | https://github.com/ossf/scorecard/blob/main/docs/checks.md#dependency-update-tool | |---------|------------------------|--------------------------------|-----------------------------------------------------------------------------------| | 0 / 10 | Fuzzing | project is not fuzzed | https://github.com/ossf/scorecard/blob/main/docs/checks.md#fuzzing | |---------|------------------------|--------------------------------|-----------------------------------------------------------------------------------| | 10 / 10 | License | license file detected | https://github.com/ossf/scorecard/blob/main/docs/checks.md#license | |---------|------------------------|--------------------------------|-----------------------------------------------------------------------------------| | 0 / 10 | Maintained | 0 commit(s) out of 30 and 1 | https://github.com/ossf/scorecard/blob/main/docs/checks.md#maintained | | | | issue activity out of 30 found | | | | | in the last 90 days -- score | | | | | normalized to 0 | | |---------|------------------------|--------------------------------|-----------------------------------------------------------------------------------| | ? | Packaging | no published package detected | https://github.com/ossf/scorecard/blob/main/docs/checks.md#packaging | |---------|------------------------|--------------------------------|-----------------------------------------------------------------------------------| | 10 / 10 | Pinned-Dependencies | all dependencies are pinned | https://github.com/ossf/scorecard/blob/main/docs/checks.md#pinned-dependencies | |---------|------------------------|--------------------------------|-----------------------------------------------------------------------------------| | 0 / 10 | SAST | SAST tool is not run on all | https://github.com/ossf/scorecard/blob/main/docs/checks.md#sast | | | | commits -- score normalized to | | | | | 0 | | |---------|------------------------|--------------------------------|-----------------------------------------------------------------------------------| | 0 / 10 | Security-Policy | security policy file not | https://github.com/ossf/scorecard/blob/main/docs/checks.md#security-policy | | | | detected | | |---------|------------------------|--------------------------------|-----------------------------------------------------------------------------------| | ? | Signed-Releases | no releases found | https://github.com/ossf/scorecard/blob/main/docs/checks.md#signed-releases | |---------|------------------------|--------------------------------|-----------------------------------------------------------------------------------| | 10 / 10 | Token-Permissions | tokens are read-only in GitHub | https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions | | | | workflows | | |---------|------------------------|--------------------------------|-----------------------------------------------------------------------------------| | 10 / 10 | Vulnerabilities | no vulnerabilities detected | https://github.com/ossf/scorecard/blob/main/docs/checks.md#vulnerabilities | |---------|------------------------|--------------------------------|-----------------------------------------------------------------------------------|

Commit Message: deps: update Ragel Additional Description: A thread of Ragel and its license has been opened in the Slack channel today. Currently, Ragel is under GPLv2. It is legal to use Ragel as a tool to compile, but we have to compile Ragel in Envoy's building system and there is potential risk of the copyright. The patch updates Ragel to the latest version with MIT license to suppress the concern. Risk Level: Low Testing: N/A Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Xie Zhihao <zhihao.xie@intel.com> Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

…23837) * backport: ci: use host docker gid for envoybuild (#23803) Previously `/var/run/docker.sock` is readable/writable inside docker run because group ID of `envoygroup` coincidentally matches host docker group, while it is no longer true during rolling out new image. Fixing that by forcing `envoygroup` has host docker group ID. Cherry-picked from: 7ac5336. Signed-off-by: Lizan Zhou <lizan@tetrate.io> Signed-off-by: Dhi Aurrahman <dio@rockybars.com> * deps: update Ragel (#22635) Commit Message: deps: update Ragel Additional Description: A thread of Ragel and its license has been opened in the Slack channel today. Currently, Ragel is under GPLv2. It is legal to use Ragel as a tool to compile, but we have to compile Ragel in Envoy's building system and there is potential risk of the copyright. The patch updates Ragel to the latest version with MIT license to suppress the concern. Risk Level: Low Testing: N/A Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Xie Zhihao <zhihao.xie@intel.com> Signed-off-by: Dhi Aurrahman <dio@rockybars.com> * Conflict Signed-off-by: Dhi Aurrahman <dio@rockybars.com> Signed-off-by: Lizan Zhou <lizan@tetrate.io> Signed-off-by: Dhi Aurrahman <dio@rockybars.com> Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>

deps: update Ragel

8d653dd

Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>

repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Aug 10, 2022

repokitteh-read-only Bot assigned htuch Aug 10, 2022

htuch reviewed Aug 10, 2022

View reviewed changes

zhxie added 3 commits August 10, 2022 14:51

deps: use GitHub repos

c1601f2

Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>

deps: fix release dates

9858b86

Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>

ci: kick CI

d0717fb

Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>

ci: kick CI

75d5533

Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>

mattklein123 reviewed Aug 10, 2022

View reviewed changes

repokitteh-read-only Bot added the waiting label Aug 10, 2022

deps: add comments

c0dd4b1

Signed-off-by: Xie Zhihao <zhihao.xie@intel.com>

repokitteh-read-only Bot removed the waiting label Aug 11, 2022

htuch reviewed Aug 11, 2022

View reviewed changes

jmarantz approved these changes Aug 17, 2022

View reviewed changes

jmarantz merged commit 835dc50 into envoyproxy:main Aug 17, 2022

moderation reviewed Aug 17, 2022

View reviewed changes

zhxie deleted the ragel-update branch September 7, 2022 08:29

phlax mentioned this pull request Nov 4, 2022

[backport/v1.23]: ci: use host docker gid for envoybuild + deps: Update ragel #23837

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update Ragel#22635

deps: update Ragel#22635
jmarantz merged 6 commits intoenvoyproxy:mainfrom
zhxie:ragel-update

zhxie commented Aug 10, 2022 •

edited

Loading

Uh oh!

repokitteh-read-only Bot commented Aug 10, 2022

Uh oh!

zhxie commented Aug 10, 2022

Uh oh!

htuch Aug 10, 2022

Uh oh!

zhxie Aug 10, 2022

Uh oh!

moderation Aug 10, 2022 •

edited

Loading

Uh oh!

zhxie Aug 10, 2022

Uh oh!

zhxie commented Aug 10, 2022

Uh oh!

repokitteh-read-only Bot commented Aug 10, 2022

Uh oh!

mattklein123 Aug 10, 2022

Uh oh!

zhxie Aug 11, 2022

Uh oh!

htuch left a comment

Uh oh!

moderation Aug 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

zhxie commented Aug 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only Bot commented Aug 10, 2022

Uh oh!

zhxie commented Aug 10, 2022

Uh oh!

htuch Aug 10, 2022

Choose a reason for hiding this comment

Uh oh!

zhxie Aug 10, 2022

Choose a reason for hiding this comment

Uh oh!

moderation Aug 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhxie Aug 10, 2022

Choose a reason for hiding this comment

Uh oh!

zhxie commented Aug 10, 2022

Uh oh!

repokitteh-read-only Bot commented Aug 10, 2022

Uh oh!

mattklein123 Aug 10, 2022

Choose a reason for hiding this comment

Uh oh!

zhxie Aug 11, 2022

Choose a reason for hiding this comment

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

moderation Aug 17, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zhxie commented Aug 10, 2022 •

edited

Loading

moderation Aug 10, 2022 •

edited

Loading