Skip to content

[backport/v1.23] tools, github: Add error handling and update README#23836

Merged
phlax merged 2 commits intoenvoyproxy:release/v1.23from
dio:write-version-update-1.23
Nov 5, 2022
Merged

[backport/v1.23] tools, github: Add error handling and update README#23836
phlax merged 2 commits intoenvoyproxy:release/v1.23from
dio:write-version-update-1.23

Conversation

@dio
Copy link
Copy Markdown
Member

@dio dio commented Nov 4, 2022

Commit Message: This makes sure we are not rate-limited when calling GitHub API

Cherry-picked from:

Risk Level: Low
Testing: Manual
Docs Changes: N/A
Release Notes: N/A
Platform-Specific Features: N/A

Cherry-picked from:

- ceb45a3
- 36fc1cc
- 3ea63d7

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
@phlax
Copy link
Copy Markdown
Member

phlax commented Nov 4, 2022

most likely we will need to backport the same fix/es to this branch also

@dio
Copy link
Copy Markdown
Member Author

dio commented Nov 4, 2022

Gotcha. Will do.

@dio
Copy link
Copy Markdown
Member Author

dio commented Nov 4, 2022

waiting for: #23837

@phlax phlax self-assigned this Nov 4, 2022
@phlax phlax added this to the 1.23.3 milestone Nov 4, 2022
@phlax
Copy link
Copy Markdown
Member

phlax commented Nov 4, 2022

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23836 (comment) was created by @phlax.

see: more, trace.

Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @dio

@phlax phlax merged commit 00666ef into envoyproxy:release/v1.23 Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants