tools, github: Pick authorization prefix based on provided token#23766
Merged
phlax merged 2 commits intoenvoyproxy:mainfrom Nov 1, 2022
Merged
tools, github: Pick authorization prefix based on provided token#23766phlax merged 2 commits intoenvoyproxy:mainfrom
phlax merged 2 commits intoenvoyproxy:mainfrom
Conversation
Member
Author
|
Hopefully, this works now. |
Member
Author
|
/assign @phlax |
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
dio
force-pushed
the
use-authorization_header_prefix
branch
from
b81ff31 to
8b4295e
Compare
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
phlax
reviewed
Nov 1, 2022
Co-authored-by: phlax <phlax@users.noreply.github.com> Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Member
Author
|
Sure. Will add. When you do it locally seems like it is rare to experience rate-limited API calls for commit info (e.g. https://api.github.com/repos/envoyproxy/envoy/commits/v1.24.0). But yeah when you do from CI, e.g. GitHub Actions it has a bigger probability. Also, +1 for clean error handling. |
Member
|
cool - i can review any follow ups - ill wait on the backport pr/s until you are happy with this on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Pick the authorization prefix based on the provided token.
Additional Description: Reference: https://github.com/octokit/auth-token.js/blob/902a172693d08de998250bf4d8acb1fdb22377a4/src/with-authorization-prefix.ts#L6-L12
Risk Level: Low
Testing: Manual
Docs Changes: N/A
Release Notes: N/A
Platform-Specific Features: N/A
Signed-off-by: Dhi Aurrahman dio@rockybars.com