Skip to content

tools, github: Pick authorization prefix based on provided token #23766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phlax merged 2 commits into from
Nov 1, 2022
Merged

tools, github: Pick authorization prefix based on provided token #23766

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b4295e
tools, github: Use authorization prefix based on provided token
dio Oct 31, 2022
328595f
Update tools/github/write_current_source_version.py
dio Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tools/github/write_current_source_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,12 @@
# Fetch the current version commit information from GitHub.
commit_info_request = urllib.request.Request(
"https://api.github.com/repos/envoyproxy/envoy/commits/v" + current_version)
github_token = os.environ.get(args.github_api_token_env_name)
if github_token != None:
if github_token := os.environ.get(args.github_api_token_env_name):
# Reference: https://github.com/octokit/auth-token.js/blob/902a172693d08de998250bf4d8acb1fdb22377a4/src/with-authorization-prefix.ts#L6-L12.
authorization_header_prefix = "bearer" if len(github_token.split(".")) is 3 else "token"
Comment thread
dio marked this conversation as resolved.
Outdated
# To avoid rate-limited API calls.
commit_info_request.add_header("Authorization", f"Bearer {github_token}")
commit_info_request.add_header(
"Authorization", f"{authorization_header_prefix} {github_token}")
with urllib.request.urlopen(commit_info_request) as response:
commit_info = json.loads(response.read())
source_version_file = project_root_dir.joinpath("SOURCE_VERSION")
Expand Down