Skip to content

[backport/v1.24] tools, github: Avoid rate-limited calls when calling GitHub API#23751

Merged
phlax merged 4 commits intoenvoyproxy:release/v1.24from
dio:write-version-update-1.24
Nov 4, 2022
Merged

[backport/v1.24] tools, github: Avoid rate-limited calls when calling GitHub API#23751
phlax merged 4 commits intoenvoyproxy:release/v1.24from
dio:write-version-update-1.24

Conversation

@dio
Copy link
Copy Markdown
Member

@dio dio commented Oct 31, 2022 •
edited
Loading

Commit Message: This makes sure we are not rate-limited when calling GitHub API

Cherry-picked from:

Risk Level: Low
Testing: Manual
Docs Changes: N/A
Release Notes: N/A
Platform-Specific Features: N/A

@dio
tools, github: Avoid rate-limited calls when calling GitHub API
b740642 
Cherry-picked from ceb45a3.

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
@dio
Copy link
Copy Markdown
Member Author

dio commented Oct 31, 2022

/assign @phlax

@dio
Copy link
Copy Markdown
Member Author

dio commented Oct 31, 2022 •
edited
Loading

wait for #23766.

@dio dio marked this pull request as draft October 31, 2022 22:59
@dio dio changed the title backport: tools, github: Avoid rate-limited calls when calling GitHub API WIP: backport: tools, github: Avoid rate-limited calls when calling GitHub API Oct 31, 2022
dio added 2 commits November 2, 2022 09:18
@dio
Pick authorization prefix based on provided token
3595e01 
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
@dio
Add error handling and update README
fa91603 
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
@dio dio changed the title WIP: backport: tools, github: Avoid rate-limited calls when calling GitHub API backport: tools, github: Avoid rate-limited calls when calling GitHub API Nov 2, 2022
@dio dio marked this pull request as ready for review November 2, 2022 10:32
@dio
Copy link
Copy Markdown
Member Author

dio commented Nov 2, 2022

/retest

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only Bot commented Nov 2, 2022

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23751 (comment) was created by @dio.

see: more, trace.

@dio
Copy link
Copy Markdown
Member Author

dio commented Nov 2, 2022

Will check if this is flaky

@dio
Copy link
Copy Markdown
Member Author

dio commented Nov 3, 2022

Probably //test/extensions/transport_sockets/tls/ocsp:ocsp_test and //test/extensions/transport_sockets/tls:ssl_socket_test are indeed flaky on 1.24.x? But mostly unknown file failure.

@dio
Copy link
Copy Markdown
Member Author

dio commented Nov 3, 2022

/retest

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only Bot commented Nov 3, 2022

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23751 (comment) was created by @dio.

see: more, trace.

@phlax
Copy link
Copy Markdown
Member

phlax commented Nov 3, 2022

seems like this has triggered all of the flakes

/retest

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only Bot commented Nov 3, 2022

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23751 (comment) was created by @phlax.

see: more, trace.

@phlax phlax mentioned this pull request Nov 3, 2022
Merged
@phlax phlax added this to the 1.24.1 milestone Nov 3, 2022
@dio dio changed the title backport: tools, github: Avoid rate-limited calls when calling GitHub API [backport/v1.24] tools, github: Avoid rate-limited calls when calling GitHub API Nov 4, 2022
phlax
phlax approved these changes Nov 4, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @dio

@phlax phlax merged commit e0ac7ef into envoyproxy:release/v1.24 Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phlax phlax phlax approved these changes

Assignees

@phlax phlax

Labels

None yet

Projects

None yet

Milestone

1.24.1

Development

Successfully merging this pull request may close these issues.

2 participants

@dio @phlax