moving original_dst cluster to extensions#23694
Merged
alyssawilk merged 8 commits intoenvoyproxy:mainfrom Nov 2, 2022
Merged
Conversation
alyssawilk
force-pushed
the
original_dst
branch
4 times, most recently
from
45bf3c0 to
3ec2fc9
Compare
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
alyssawilk
force-pushed
the
original_dst
branch
from
3ec2fc9 to
6509678
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
original_dst
branch
from
6509678 to
e828550
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
cc @yanavlasov not sure of the impact on import - can you loop in the relevant people? |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
kyessenov
previously approved these changes
Oct 27, 2022
yanavlasov
previously approved these changes
Oct 28, 2022
Contributor
|
Windows test failure seems legit, although I do not understand why it is failing for Windows only. |
Contributor
|
/wait |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Contributor
Author
|
Passing CI finally but needs an API stamp again :-( |
This was referenced Nov 3, 2022
alyssawilk
added a commit
that referenced
this pull request
Nov 9, 2022
) Any Envoy users who customize their pre-built extensions will need to evaluate if they need this cluster. Akin to #23694 Risk Level: medium Testing: n/a Docs Changes: n/a Release Notes: inline Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
added a commit
that referenced
this pull request
Nov 9, 2022
Any Envoy users who customize their pre-built extensions will need to evaluate if they need this cluster. Akin to #23694 Risk Level: medium Testing: n/a Docs Changes: n/a Release Notes: inline Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
added a commit
that referenced
this pull request
Nov 16, 2022
* build: moving eds cluster to extensions Signed-off-by: Alyssa Wilk <alyssar@chromium.org> * format Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Any Envoy users who customize their pre-built extensions will need to evaluate if they need this cluster. Akin to #23694 Risk Level: medium Testing: n/a Docs Changes: n/a Release Notes: inline Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any Envoy users who customize their pre-built extensions will need to evaluate if they need this cluster.
Risk Level: medium
Testing: n/a
Docs Changes: n/a
Release Notes: inline