build: Moving the strict DNS cluster into an extension directory#23808
Merged
alyssawilk merged 4 commits intoenvoyproxy:mainfrom Nov 9, 2022
Merged
build: Moving the strict DNS cluster into an extension directory#23808alyssawilk merged 4 commits intoenvoyproxy:mainfrom
alyssawilk merged 4 commits intoenvoyproxy:mainfrom
Conversation
alyssawilk
force-pushed
the
strict_dns_cluster_lib
branch
from
ee41cd6 to
258ff7a
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
strict_dns_cluster_lib
branch
from
258ff7a to
32204bd
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
jmarantz
reviewed
Nov 8, 2022
Contributor
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
This looks simple enough but I'd like @yanjunxiang-google to look at it.
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
| #include "source/common/singleton/manager_impl.h" | ||
| #include "source/common/upstream/static_cluster.h" | ||
| #include "source/common/upstream/strict_dns_cluster.h" | ||
| #include "source/extensions/clusters/strict_dns/strict_dns_cluster.h" |
Contributor
There was a problem hiding this comment.
Does this break the rule that the core tests should not depend on extensions?
Contributor
There was a problem hiding this comment.
And will the envoy.clusters.strict_dns: be in the required extensions as in here:
Contributor
Author
There was a problem hiding this comment.
it does not - we frequently have core code in extensions directory (e.g. raw buffer socket)
Also I don't think it hsould be in required extensions as the whole point of moving it out was to not link it for Envoy Mobile and we can't override that.
Contributor
|
LGTM. @yanavlasov, PTAL |
jmarantz
approved these changes
Nov 9, 2022
This was referenced Nov 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any Envoy users who customize their pre-built extensions will need to evaluate if they need this cluster.
Akin to #23694
Risk Level: medium
Testing: n/a
Docs Changes: n/a
Release Notes: inline