Skip to content

build: moving static clusters into an extension directory#23890

Merged
alyssawilk merged 2 commits intoenvoyproxy:mainfrom
alyssawilk:static_cluster
Nov 9, 2022
Merged

build: moving static clusters into an extension directory#23890
alyssawilk merged 2 commits intoenvoyproxy:mainfrom
alyssawilk:static_cluster

Conversation

@alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented Nov 8, 2022

Any Envoy users who customize their pre-built extensions will need to evaluate if they need this cluster.
Akin to #23694

Risk Level: medium
Testing: n/a
Docs Changes: n/a
Release Notes: inline

@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #23890 was opened by alyssawilk.

see: more, trace.

@alyssawilk alyssawilk force-pushed the static_cluster branch 3 times, most recently from 45fd6df to 86cdb68 Compare November 8, 2022 17:57
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk alyssawilk marked this pull request as ready for review November 9, 2022 16:43
@alyssawilk alyssawilk requested a review from snowp as a code owner November 9, 2022 16:43
@alyssawilk alyssawilk changed the title Static cluster build: moving static clusters into an extension directory Nov 9, 2022
@alyssawilk alyssawilk enabled auto-merge (squash) November 9, 2022 16:44
@alyssawilk alyssawilk merged commit 88df4c7 into envoyproxy:main Nov 9, 2022
mum4k pushed a commit to envoyproxy/nighthawk that referenced this pull request Nov 16, 2022
1. Update ENVOY_COMMIT to [23917](envoyproxy/envoy#23917)
3. Update the way of initiating ClusterManagerFactory object in source/client/process_impl.cc due to envoy commit [23917](envoyproxy/envoy#23917)
4. Include cares, static and strict_dns in extensions_build_config.bzl due to envoy commit [23890](envoyproxy/envoy#23890)

Signed-off-by: fei-deng <feid@google.com>
@alyssawilk alyssawilk deleted the static_cluster branch April 5, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants