Skip to content

backport: c++: provide type to std::weak_ptr template #23177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wbpcode merged 1 commit into from
Sep 20, 2022
Merged

backport: c++: provide type to std::weak_ptr template #23177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions source/extensions/filters/http/file_system_buffer/filter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,9 +399,10 @@ bool FileSystemBufferFilter::maybeStorage(BufferedStreamState& state,
// We can't use getSafeDispatcher here because we need to close the file if the filter
// was deleted before the callback, not just do nothing.
cancel_in_flight_async_action_ = config_->asyncFileManager().createAnonymousFile(
config_->storageBufferPath(), [this, me = std::weak_ptr(shared_from_this()),
dispatcher = &request_callbacks_->dispatcher(),
&state](absl::StatusOr<AsyncFileHandle> file_handle) {
config_->storageBufferPath(),
[this, me = std::weak_ptr<FileSystemBufferFilter>(shared_from_this()),
dispatcher = &request_callbacks_->dispatcher(),
&state](absl::StatusOr<AsyncFileHandle> file_handle) {
dispatcher->post([this, me = std::move(me), &state, file_handle]() {
if (!me.lock()) {
// If we opened a file but the filter went away in the meantime, close the file
Expand Down