Skip to content

envoy 1.23.0#105900

Closed
chenrui333 wants to merge 1 commit intoHomebrew:masterfrom
chenrui333:bump-envoy-1.23.0
Closed

envoy 1.23.0#105900
chenrui333 wants to merge 1 commit intoHomebrew:masterfrom
chenrui333:bump-envoy-1.23.0

Conversation

@chenrui333
Copy link
Copy Markdown
Member

Created by brew bump


Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` labels Jul 16, 2022
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jul 16, 2022
@chenrui333
Copy link
Copy Markdown
Member Author

  source/extensions/filters/http/file_system_buffer/filter.cc:402:53: error: no viable constructor or deduction guide for deduction of template arguments of 'weak_ptr'
            config_->storageBufferPath(), [this, me = std::weak_ptr(shared_from_this()),
                                                      ^
...
  source/extensions/filters/http/file_system_buffer/filter.cc:405:52: error: use of undeclared identifier 'me'
              dispatcher->post([this, me = std::move(me), &state, file_handle]() {
                                                     ^
  source/extensions/filters/http/file_system_buffer/filter.cc:406:20: error: use of undeclared identifier 'me'
                if (!me.lock()) {
                     ^
  3 errors generated.

@chenrui333 chenrui333 added build failure CI fails while building the software 10.15 Catalina is specifically affected labels Jul 16, 2022
@cho-m cho-m added the long build Set a long timeout for formula testing label Jul 16, 2022
@Moisan Moisan mentioned this pull request Jul 17, 2022
@chenrui333 chenrui333 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 17, 2022
@fxcoudert fxcoudert removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jul 18, 2022
@cho-m
Copy link
Copy Markdown
Member

cho-m commented Jul 19, 2022

LLVM may need llvm/llvm-project@8356405 which was added to LLVM 11

  • macOS 10.15 runner uses Xcode 12.4 / Apple Clang 12.0.0, which maps to LLVM 10.0.0
  • Xcode 12.5 / Apple Clang 12.0.5 updated to LLVM 11.1.0.

In current version, can try using llvm formula or making :big_sur the minimum.

Alternatively, can check with upstream as https://github.com/envoyproxy/envoy/tree/main/bazel#supported-compiler-versions claims minimum LLVM/Clang as 9 (though they test with 14). Not sure how reliable that page is given that GCC claims 9+ but I haven't been able to build with GCC 10+.

@cpakulski
Copy link
Copy Markdown
Contributor

It seems like c++ problem. I opened Envoy PR to fix it, but nothing can be done for Envoy's release 1.23.0. Can we accept the fact that brew will not provide Envoy's release 1.23.0 on 10.15?

@SMillerDev
Copy link
Copy Markdown
Member

We can't update partially. Either brew provides 1.23.0 or it doesn't.

@cpakulski
Copy link
Copy Markdown
Contributor

The options to fix it are:

  • upgrade compilers used on 10.15
  • run a simple text reformatting after cloning repo. The fix is in the single line of c++ code.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions Bot added the stale No recent activity label Jul 24, 2022
@github-actions github-actions Bot closed this Jul 25, 2022
@github-actions github-actions Bot added the outdated PR was locked due to age label Aug 25, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 25, 2022
@chenrui333 chenrui333 deleted the bump-envoy-1.23.0 branch December 18, 2022 06:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

10.15 Catalina is specifically affected automerge-skip `brew pr-automerge` will skip this pull request build failure CI fails while building the software bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing outdated PR was locked due to age stale No recent activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants