Skip to content

[TESTING] Release testing#22199

Closed
phlax wants to merge 2 commits intoenvoyproxy:mainfrom
phlax:release-testing
Closed

[TESTING] Release testing#22199
phlax wants to merge 2 commits intoenvoyproxy:mainfrom
phlax:release-testing

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Jul 14, 2022

testing merged branches for release

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #22199 was opened by phlax.

see: more, trace.

@phlax phlax marked this pull request as draft July 14, 2022 10:00
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jul 14, 2022

/docs

@repokitteh-read-only
Copy link
Copy Markdown

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/22199/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: a #22199 (comment) was created by @phlax.

see: more, trace.

@phlax phlax added this to the 1.23.0 milestone Jul 14, 2022
@phlax phlax force-pushed the release-testing branch 5 times, most recently from d1562bb to 420bf14 Compare July 15, 2022 13:01
@phlax phlax force-pushed the release-testing branch 2 times, most recently from 45d2b9b to 97c04b3 Compare July 15, 2022 15:52
@phlax phlax removed the api label Jul 15, 2022
phlax and others added 2 commits July 15, 2022 18:13
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the release-testing branch from 97c04b3 to e5a3880 Compare July 15, 2022 18:01
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jul 15, 2022

@adisuissa i tested locally with AZP_BRANCH set - docs were built correctly, in the right place, and with correct tags etc - so i think all is good

ill close this when it goes green

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jul 15, 2022

and closed 🎉

@phlax phlax closed this Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants