Skip to content

bazel: update to latest rolling release #21070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keith merged 2 commits into from
Apr 29, 2022
Merged

bazel: update to latest rolling release #21070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe62ee0
bazel: update `.bazelversion` to latest rolling release
jpsim Apr 28, 2022
da96339
Bump windows CI timeout to 180 minutes
jpsim Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .azure-pipelines/pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ stages:
dependsOn: ["precheck"]
jobs:
- job: release
timeoutInMinutes: 120
timeoutInMinutes: 180
Copy link
Copy Markdown
Contributor Author

@jpsim jpsim Apr 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably we'll be able to revert this once caches are warm.

Copy link
Copy Markdown
Member

@keith keith Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if this was required once we should leave it, since it could happen at any normal tooling update too then.

pool:
vmImage: "windows-2019"
steps:
Expand Down
2 changes: 1 addition & 1 deletion .bazelversion
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
5.1.1
6.0.0-pre.20220414.2
Copy link
Copy Markdown
Contributor

@yanavlasov yanavlasov Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need toolchain update for this or do we use bazilisk in build images?

Copy link
Copy Markdown
Contributor Author

@jpsim jpsim Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this log from CI, it seems like bazelisk is used and the correct bazel version is pulled when building:

2022/04/28 19:31:04 Downloading https://github.com/bazelbuild/bazel/releases/download/6.0.0-pre.20220414.2/bazel-6.0.0-pre.20220414.2-linux-x86_64...

Copy link
Copy Markdown
Member

@keith keith Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in general the toolchains are pretty stable, so Ideally we won't have to change them much