Revert "router: Remove PathMatchType and PathMatchCriterion (#20649)"#20797
Merged
yanavlasov merged 2 commits intoenvoyproxy:mainfrom Apr 13, 2022
Merged
Revert "router: Remove PathMatchType and PathMatchCriterion (#20649)"#20797yanavlasov merged 2 commits intoenvoyproxy:mainfrom
yanavlasov merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Contributor
Author
Contributor
|
LGTM |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
yanavlasov
approved these changes
Apr 13, 2022
Contributor
|
Per comments in #20649, merging. |
vehre-x41
pushed a commit
to vehre-x41/envoy
that referenced
this pull request
Apr 19, 2022
…xy#20649)" (envoyproxy#20797) * Revert "router: Remove PathMatchType and PathMatchCriterion (envoyproxy#20649)" This reverts commit 7014ce6. Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Andre Vehreschild <vehre@x41-dsec.de>
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…xy#20649)" (envoyproxy#20797) * Revert "router: Remove PathMatchType and PathMatchCriterion (envoyproxy#20649)" This reverts commit 7014ce6. Signed-off-by: Adi Suissa-Peleg <adip@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Revert "router: Remove PathMatchType and PathMatchCriterion #20469"
Additional Description:
This reverts commit 7014ce6fd31ef7a2f6a2083d99d4b85bbe55b6c6.
The object is used by extensions to gather more information about route matching (see: #2531).
Added additional comment to
PathMatchCriterionthat explains this.Risk Level: Low
Testing: N/A.
Docs Changes: N/A.
Release Notes: N/A.
Platform Specific Features: N/A.