router: Remove PathMatchType and PathMatchCriterion

[tpetkov-VMW]

Signed-off-by: Toma Petkov tpetkov@vmware.com

Commit Message: Remove PathMatchType enum and PathMatchCriterion class, as they aren't used anywhere.
Additional Description: PathMatchCriterion class is never instantiated anywhere, besides for inheritance and testing.
Risk Level: Low
Testing: Unit test (test/common/router)
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

[tpetkov-VMW]

Proposal to remove PathMatchCriterion, based only on the codebase.
If there are, for example, pending changes that depend on it, I'll just close the PR.

[wrowe]

@htuch it appears you merged and @mrice32 made the initial contribution, if we can get some insight on why it goes unused, or approval to remove it?

[wrowe]

/assign-from envoyproxy/envoy-maintainers

[repokitteh-read-only]

envoyproxy/envoy-maintainers assignee is @mattklein123

🐱

Caused by: a #20649 (comment) was created by @wrowe.

see: more, trace.

[mattklein123]

I don't recall the history on this. It seems fine to remove. Thank you!

[htuch]

+1

[stevenzzzz]

hi there, this PR breaks our system, I think we need to reverse this PR if no strong opinion.

TLDR we need this field to take a peek into how route selection works.

Please see the original issue/PR for reference: #2531

[stevenzzzz]

@htuch

[mattklein123]

Sure feel free to revert but please add comments/tests that make it clear this is used in private extensions so it doesn't get removed again.

[stevenzzzz]

thanks. @adisuissa could you please revert this as we've discussed.