connection: don't raise connected event if connection already closed#20469
Merged
mattklein123 merged 4 commits intomainfrom Mar 23, 2022
Merged
connection: don't raise connected event if connection already closed#20469mattklein123 merged 4 commits intomainfrom
mattklein123 merged 4 commits intomainfrom
Conversation
Fixes #20438 Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
cc @ravenblackx |
mattklein123
commented
Mar 22, 2022
| // connected events. | ||
| // If a previous connected callback closed the connection, don't raise any further connected | ||
| // events. There was already recursion raising closed events. | ||
| if (event == ConnectionEvent::Connected && state() != State::Open) { |
Member
Author
There was a problem hiding this comment.
cc @danzh2010 I think this will be a semantic merge conflict with your ongoing change FYI.
Contributor
There was a problem hiding this comment.
should this change be applied to any non-close event? instead of event == ConnectionEvent::Connected, using event != ConnectionEvent::LocalClosed && event != ConnectionEvent::RemoteClosed
Member
Author
There was a problem hiding this comment.
Sure happy to make that change. Either way it's pretty fragile. :(
Contributor
|
/retest |
|
Retrying Azure Pipelines: |
alyssawilk
reviewed
Mar 23, 2022
Signed-off-by: Matt Klein <mklein@lyft.com>
alyssawilk
approved these changes
Mar 23, 2022
ravenblackx
pushed a commit
to ravenblackx/envoy
that referenced
this pull request
Jun 8, 2022
…nvoyproxy#20469) Fixes envoyproxy#20438 Signed-off-by: Matt Klein <mklein@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20438
Risk Level: Medium. Should be OK but still scary.
Testing: Modified UT.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A