[WIP] deps: Use pypi for google.* deps#18737
Closed
phlax wants to merge 2 commits intoenvoyproxy:mainfrom
Closed
Conversation
repokitteh-read-only
bot
added
the
deps
phlax
changed the title
google.* depsgoogle.* deps
phlax
force-pushed
the
deps-google-pypi
branch
2 times, most recently
from
0032761 to
9f72a51
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
deps-google-pypi
branch
from
9f72a51 to
cf7df71
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
Member
Author
|
closing this and merging with #18471 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message:
Additional Description:
This swaps the bazel google (api/protobuf) python deps for the ones on pypi - currently just for protoxform, as these deps are/were having namespace issues
I need to run it through and check if it allows us to update the bazel protobuf more generally.
Also, there are a few other places where the protobuf python dep is currently included/built, which for consistency should use these deps instead i think
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]