Skip to content

cleanup: various tiny cleanup#18287

Merged
lizan merged 1 commit intoenvoyproxy:mainfrom
lambdai:minorfix0920
Sep 29, 2021
Merged

cleanup: various tiny cleanup#18287
lizan merged 1 commit intoenvoyproxy:mainfrom
lambdai:minorfix0920

Conversation

@lambdai
Copy link
Contributor

@lambdai lambdai commented Sep 28, 2021

Commit Message:
Return bool type on empty() function per #18057 (comment)
With the stacked clean up.

Signed-off-by: Yuchen Dai silentdai@gmail.com

Additional Description:
Risk Level: LOW
Testing: Unit test
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Yuchen Dai <silentdai@gmail.com>
@lambdai lambdai requested a review from zuercher as a code owner September 28, 2021 06:38
@lizan
Copy link
Member

lizan commented Sep 28, 2021

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18287 (comment) was created by @lizan.

see: more, trace.

@lambdai
Copy link
Contributor Author

lambdai commented Sep 28, 2021

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18287 (comment) was created by @lambdai.

see: more, trace.

@lizan lizan merged commit 5599a9f into envoyproxy:main Sep 29, 2021
@lambdai lambdai deleted the minorfix0920 branch September 29, 2021 04:18
mpuncel added a commit to mpuncel/envoy that referenced this pull request Oct 29, 2021
* main: (114 commits)
  kafka: add header support to mesh-filter (envoyproxy#18248)
  rbac: add support for upstream ip policy. (envoyproxy#17645)
  SIPProxy BUGFIX UT failure for fastbuild/debug (envoyproxy#18303)
  quic: updating goaway code (envoyproxy#18291)
  various tiny fixes (envoyproxy#18287)
  dns cache: remove assert at this layer (envoyproxy#18301)
  [ext_authz]: ext_authz filter unit test that use real threading (envoyproxy#17742)
  signal action: fully disable sigaltstack on Apple (envoyproxy#18299)
  Add missing dependencies (envoyproxy#18297)
  ext_proc: Pass stream_info to gRPC streams (envoyproxy#18190)
  use clang 12 (envoyproxy#18220)
  Update PR template to include the "Fixes commit" message when reverting or fixing bad commits (envoyproxy#18298)
  [test] Fixing integration test to cleanup cleanly (envoyproxy#18293)
  test: moving grpc bridge tests out of core directory (envoyproxy#18227)
  runtime: disable deprecated extensions names by default (envoyproxy#18239)
  quiche: updating deps (envoyproxy#18272)
  sip_proxy: SIP protocol support in envoy (envoyproxy#18039)
  http: add core retry policy to route retry policy conversion utility (envoyproxy#17803)
  build: updating stale visibility (envoyproxy#18278)
  alternate_protocols_cache: Impose a max size limit on the alternate protocols cache (envoyproxy#18258)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants