Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
repokitteh-read-only
bot
added
the
deps
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
|
FYI I needed the test change as the QUIC test got way flakier failing a client side assert that the handshake is finalized before we tried port migration. Not sure why, but waiting for handshake completion seemed reasonable so I went with that. |
Drive-by: I noticed the same thing when I write tests for my port migration PR. And yeah the tests should wait for handshake confirmed to performa port migration anyway. |
Probably a recent QUICHE update flips connection migration related flags that disallows peer address change before handshake gets confirmed. |
danzh2010
left a comment
danzh2010
left a comment
There was a problem hiding this comment.
LGTM along aside mac CI failure.
* main: (114 commits) kafka: add header support to mesh-filter (envoyproxy#18248) rbac: add support for upstream ip policy. (envoyproxy#17645) SIPProxy BUGFIX UT failure for fastbuild/debug (envoyproxy#18303) quic: updating goaway code (envoyproxy#18291) various tiny fixes (envoyproxy#18287) dns cache: remove assert at this layer (envoyproxy#18301) [ext_authz]: ext_authz filter unit test that use real threading (envoyproxy#17742) signal action: fully disable sigaltstack on Apple (envoyproxy#18299) Add missing dependencies (envoyproxy#18297) ext_proc: Pass stream_info to gRPC streams (envoyproxy#18190) use clang 12 (envoyproxy#18220) Update PR template to include the "Fixes commit" message when reverting or fixing bad commits (envoyproxy#18298) [test] Fixing integration test to cleanup cleanly (envoyproxy#18293) test: moving grpc bridge tests out of core directory (envoyproxy#18227) runtime: disable deprecated extensions names by default (envoyproxy#18239) quiche: updating deps (envoyproxy#18272) sip_proxy: SIP protocol support in envoy (envoyproxy#18039) http: add core retry policy to route retry policy conversion utility (envoyproxy#17803) build: updating stale visibility (envoyproxy#18278) alternate_protocols_cache: Impose a max size limit on the alternate protocols cache (envoyproxy#18258) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
5 participants
Signed-off-by: Alyssa Wilk alyssar@chromium.org
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]