runtime: disable deprecated extensions names by default#18239
Merged
zuercher merged 7 commits intoenvoyproxy:mainfrom Sep 28, 2021
Merged
Conversation
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
zuercher
requested review from
alyssawilk,
asraa,
dio,
ggreenway,
lizan,
mattklein123 and
snowp
as code owners
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Member
Author
|
cc @alyssawilk |
alyssawilk
reviewed
Sep 23, 2021
| } | ||
|
|
||
| // Test that the deprecated extension name still functions. | ||
| // Test that the deprecated extension name is disabled by default. |
Contributor
There was a problem hiding this comment.
So I'm fine with all of these testing failure by default but if we hit coverage issue we may want to TestScopedRuntime these back to the prior behavior
Member
Author
There was a problem hiding this comment.
I think the coverage is fine because there's still a test that exercises the logging path (e.g. when the runtime flag is enabled).
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
alyssawilk
approved these changes
Sep 24, 2021
Member
Author
|
Does this need another approval or is it minor enough that I should just merge it? |
Contributor
|
yeah AFIK I had approved and you retested? |
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Oct 29, 2021
* main: (114 commits) kafka: add header support to mesh-filter (envoyproxy#18248) rbac: add support for upstream ip policy. (envoyproxy#17645) SIPProxy BUGFIX UT failure for fastbuild/debug (envoyproxy#18303) quic: updating goaway code (envoyproxy#18291) various tiny fixes (envoyproxy#18287) dns cache: remove assert at this layer (envoyproxy#18301) [ext_authz]: ext_authz filter unit test that use real threading (envoyproxy#17742) signal action: fully disable sigaltstack on Apple (envoyproxy#18299) Add missing dependencies (envoyproxy#18297) ext_proc: Pass stream_info to gRPC streams (envoyproxy#18190) use clang 12 (envoyproxy#18220) Update PR template to include the "Fixes commit" message when reverting or fixing bad commits (envoyproxy#18298) [test] Fixing integration test to cleanup cleanly (envoyproxy#18293) test: moving grpc bridge tests out of core directory (envoyproxy#18227) runtime: disable deprecated extensions names by default (envoyproxy#18239) quiche: updating deps (envoyproxy#18272) sip_proxy: SIP protocol support in envoy (envoyproxy#18039) http: add core retry policy to route retry policy conversion utility (envoyproxy#17803) build: updating stale visibility (envoyproxy#18278) alternate_protocols_cache: Impose a max size limit on the alternate protocols cache (envoyproxy#18258) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies the default value when looking up
envoy.deprecated_features.allow_deprecated_extension_namessuch that deprecated extension names (e.g.envoy.routerinstead ofenvoy.filters.http.router) are no longer allowed. The deprecated names have been logged as such since Envoy 1.14.0. See #18238 which tracks removing this feature altogether.Risk Level: low
Testing: updated unit tests
Docs Changes: n/a
Release Notes: updated
Platform Specific Features: n/a
Runtime guard: envoy.deprecated_features.allow_deprecated_extension_names